superset-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From maximebeauche...@apache.org
Subject [incubator-superset] branch master updated: fix(filterbox): fixed runtime exception in filterbox for allow multiple selection is false (#7011)
Date Sun, 23 Jun 2019 21:22:13 GMT
This is an automated email from the ASF dual-hosted git repository.

maximebeauchemin pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git


The following commit(s) were added to refs/heads/master by this push:
     new 9c0c16c  fix(filterbox): fixed  runtime exception in filterbox for allow multiple
selection is false (#7011)
9c0c16c is described below

commit 9c0c16c71b0fd9ef82b86f7fbf0f9d297820436a
Author: jiten-github <jitendra.kumawat@guavus.com>
AuthorDate: Mon Jun 24 02:52:07 2019 +0530

    fix(filterbox): fixed  runtime exception in filterbox for allow multiple selection is
false (#7011)
---
 superset/utils/core.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/superset/utils/core.py b/superset/utils/core.py
index c2ad7a7..d7a95ec 100644
--- a/superset/utils/core.py
+++ b/superset/utils/core.py
@@ -840,7 +840,7 @@ def merge_extra_filters(form_data: dict):
             if date_options.get(filtr['col']):
                 if filtr.get('val'):
                     form_data[date_options[filtr['col']]] = filtr['val']
-            elif filtr['val'] and len(filtr['val']):
+            elif filtr['val']:
                 # Merge column filters
                 filter_key = get_filter_key(filtr)
                 if filter_key in existing_filters:


Mime
View raw message