superset-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From b...@apache.org
Subject [incubator-superset] branch master updated: Autocomplete in the table browser in SQL lab is broken (#7736)
Date Wed, 19 Jun 2019 23:59:49 GMT
This is an automated email from the ASF dual-hosted git repository.

beto pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git


The following commit(s) were added to refs/heads/master by this push:
     new d1b81e0  Autocomplete in the table browser in SQL lab is broken (#7736)
d1b81e0 is described below

commit d1b81e04ac7a8d4e877471432c9bccbd7b369f81
Author: Kim Truong <47833996+khtruong@users.noreply.github.com>
AuthorDate: Wed Jun 19 16:59:39 2019 -0700

    Autocomplete in the table browser in SQL lab is broken (#7736)
    
    * fix: explicitly provide value and label strings
    
    * fix: spacing
---
 superset/assets/src/components/TableSelector.jsx | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/superset/assets/src/components/TableSelector.jsx b/superset/assets/src/components/TableSelector.jsx
index 6d232d4..4d5fbc9 100644
--- a/superset/assets/src/components/TableSelector.jsx
+++ b/superset/assets/src/components/TableSelector.jsx
@@ -130,7 +130,12 @@ export default class TableSelector extends React.PureComponent {
           `${encodeURIComponent(schema)}/${encodeURIComponent(substr)}/${forceRefresh}/`);
        return SupersetClient.get({ endpoint })
         .then(({ json }) => {
-          const filterOptions = createFilterOptions({ options: json.options });
+          const filterOptions = createFilterOptions({
+            options: json.options.map(o => ({
+              value: o.value.table,
+              label: o.label,
+            })),
+          });
           this.setState(() => ({
             filterOptions,
             tableLoading: false,


Mime
View raw message