superset-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From maximebeauche...@apache.org
Subject [incubator-superset] branch master updated: css: add margin-top to ResultSet (#7679)
Date Tue, 18 Jun 2019 05:57:46 GMT
This is an automated email from the ASF dual-hosted git repository.

maximebeauchemin pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git


The following commit(s) were added to refs/heads/master by this push:
     new f278faa  css: add margin-top to ResultSet (#7679)
f278faa is described below

commit f278faa8be4ead1046c0b41c482d27f4f93976b4
Author: Maxime Beauchemin <maximebeauchemin@gmail.com>
AuthorDate: Mon Jun 17 22:57:40 2019 -0700

    css: add margin-top to ResultSet (#7679)
---
 superset/assets/src/SqlLab/components/ResultSet.jsx | 2 ++
 superset/assets/src/SqlLab/main.less                | 8 ++++++++
 2 files changed, 10 insertions(+)

diff --git a/superset/assets/src/SqlLab/components/ResultSet.jsx b/superset/assets/src/SqlLab/components/ResultSet.jsx
index 7ac04b3..e0dd570 100644
--- a/superset/assets/src/SqlLab/components/ResultSet.jsx
+++ b/superset/assets/src/SqlLab/components/ResultSet.jsx
@@ -73,6 +73,7 @@ export default class ResultSet extends React.PureComponent {
     // when new results comes in, save them locally and clear in store
     if (this.props.cache && (!nextProps.query.cached)
       && nextProps.query.results
+      && nextProps.query.results.data
       && nextProps.query.results.data.length > 0) {
       this.setState(
         { data: nextProps.query.results.data },
@@ -231,6 +232,7 @@ export default class ResultSet extends React.PureComponent {
       return (
         <Button
           bsSize="sm"
+          className="fetch"
           bsStyle="primary"
           onClick={this.reFetchQueryResults.bind(this, query)}
         >
diff --git a/superset/assets/src/SqlLab/main.less b/superset/assets/src/SqlLab/main.less
index 98759ca..725ea99 100644
--- a/superset/assets/src/SqlLab/main.less
+++ b/superset/assets/src/SqlLab/main.less
@@ -421,3 +421,11 @@ a.Link {
         margin-right: 3px;
     }
 }
+
+.SouthPane .tab-content .alert {
+    margin-top: 10px;
+}
+
+.SouthPane .tab-content button.fetch {
+    margin-top: 10px;
+}


Mime
View raw message