superset-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From grace...@apache.org
Subject [incubator-superset] branch master updated: [dashboard] click tab anchor link (#7640)
Date Mon, 03 Jun 2019 23:57:32 GMT
This is an automated email from the ASF dual-hosted git repository.

graceguo pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git


The following commit(s) were added to refs/heads/master by this push:
     new f99ae1a  [dashboard] click tab anchor link (#7640)
f99ae1a is described below

commit f99ae1ad247298c8b8df3721768f69b13152aef0
Author: Grace Guo <grace.guo@airbnb.com>
AuthorDate: Mon Jun 3 16:57:21 2019 -0700

    [dashboard] click tab anchor link (#7640)
---
 superset/assets/src/components/AnchorLink.jsx | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/superset/assets/src/components/AnchorLink.jsx b/superset/assets/src/components/AnchorLink.jsx
index b33ee60..dac5e25 100644
--- a/superset/assets/src/components/AnchorLink.jsx
+++ b/superset/assets/src/components/AnchorLink.jsx
@@ -66,8 +66,7 @@ class AnchorLink extends React.PureComponent {
   }
 
   handleClickAnchorLink(ev) {
-    ev.preventDefault();
-    history.pushState(null, null, `#${this.props.anchorLinkId}`);
+    ev.stopPropagation();
   }
 
   render() {
@@ -76,6 +75,7 @@ class AnchorLink extends React.PureComponent {
       <span
         className="anchor-link-container"
         id={anchorLinkId}
+        onClick={this.handleClickAnchorLink}
       >
         {showShortLinkButton &&
         <URLShortLinkButton


Mime
View raw message