superset-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From maximebeauche...@apache.org
Subject [incubator-superset] branch master updated: [FAB] set AppBuilder to update_perms=False (#7561)
Date Sat, 01 Jun 2019 17:19:55 GMT
This is an automated email from the ASF dual-hosted git repository.

maximebeauchemin pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git


The following commit(s) were added to refs/heads/master by this push:
     new eb42936  [FAB] set AppBuilder to update_perms=False (#7561)
eb42936 is described below

commit eb4293654e8557a208a7a08b71ab22163c428362
Author: Maxime Beauchemin <maximebeauchemin@gmail.com>
AuthorDate: Sat Jun 1 10:19:49 2019 -0700

    [FAB] set AppBuilder to update_perms=False (#7561)
    
    * [FAB] set AppBuilder to update_perms=False
    
    Upon start, by default, FAB tries to go and update the permission list
    in the database based on the list of views, models and menu items that
    exist in the code.
    
    Really this should happen once per deployment/upgrade and
    not in module scope, so we have `superset init` for this.
    
    The intent was always to set to False by default, but I think we forgot
    to add this flag back in
    https://github.com/apache/incubator-superset/pull/7323
    
    * Add superset init to tox
---
 superset/__init__.py | 1 +
 tox.ini              | 1 +
 2 files changed, 2 insertions(+)

diff --git a/superset/__init__.py b/superset/__init__.py
index 6971dc9..d03f28e 100644
--- a/superset/__init__.py
+++ b/superset/__init__.py
@@ -203,6 +203,7 @@ with app.app_context():
         base_template='superset/base.html',
         indexview=MyIndexView,
         security_manager_class=custom_sm,
+        update_perms=False,  # Run `superset init` to update FAB's perms
     )
 
 security_manager = appbuilder.sm
diff --git a/tox.ini b/tox.ini
index dbe2baa..8b39058 100644
--- a/tox.ini
+++ b/tox.ini
@@ -48,6 +48,7 @@ require-code = true
 [testenv]
 commands =
     {toxinidir}/superset/bin/superset db upgrade
+    {toxinidir}/superset/bin/superset init
     nosetests tests/load_examples_test.py
     nosetests -e load_examples_test {posargs}
 deps =


Mime
View raw message