superset-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From christ...@apache.org
Subject [incubator-superset] branch lyftga updated: [filter_box] allow empty filters list (#7220)
Date Fri, 05 Apr 2019 05:17:43 GMT
This is an automated email from the ASF dual-hosted git repository.

christine pushed a commit to branch lyftga
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git


The following commit(s) were added to refs/heads/lyftga by this push:
     new e39b169  [filter_box] allow empty filters list (#7220)
e39b169 is described below

commit e39b16994946b2a7975af3ed76245e77303329e2
Author: Maxime Beauchemin <maximebeauchemin@gmail.com>
AuthorDate: Thu Apr 4 22:17:35 2019 -0700

    [filter_box] allow empty filters list (#7220)
    
    in some cases, people want a time filter only on filter box, without
    specifying dimensions (filters), this allows that
---
 superset/assets/src/explore/controls.jsx | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/superset/assets/src/explore/controls.jsx b/superset/assets/src/explore/controls.jsx
index eb1f670..be1e56f 100644
--- a/superset/assets/src/explore/controls.jsx
+++ b/superset/assets/src/explore/controls.jsx
@@ -2382,7 +2382,7 @@ export const controls = {
     type: 'CollectionControl',
     label: 'Filters',
     description: t('Filter configuration for the filter box'),
-    validators: [v.nonEmpty],
+    validators: [],
     controlName: 'FilterBoxItemControl',
     mapStateToProps: ({ datasource }) => ({ datasource }),
   },


Mime
View raw message