superset-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
Subject [incubator-superset] branch lyftga updated: [bugfix] SQL Lab 'Filter Results' doesn't stick (#7104)
Date Fri, 29 Mar 2019 01:05:23 GMT
This is an automated email from the ASF dual-hosted git repository.

christine pushed a commit to branch lyftga
in repository

The following commit(s) were added to refs/heads/lyftga by this push:
     new 0ea1b42  [bugfix] SQL Lab 'Filter Results' doesn't stick (#7104)
0ea1b42 is described below

commit 0ea1b42db03bfa139532271ecc94cf44c95537c1
Author: Maxime Beauchemin <>
AuthorDate: Wed Mar 27 17:53:32 2019 -0700

    [bugfix] SQL Lab 'Filter Results' doesn't stick (#7104)
    When using a "Search Results" criteria, the subset of rows that match
    the criteria get displayed. While this the filter is applied, if another
    query is run, the filter is still active, but not displayed in the input
    text box. After this change, the state of the input box sticks after
    subsequent queries.
    (cherry picked from commit d5e8d663dc63ee9b99b3e7bb4e91512fa32ed1e0)
 superset/assets/src/SqlLab/components/ResultSet.jsx | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/superset/assets/src/SqlLab/components/ResultSet.jsx b/superset/assets/src/SqlLab/components/ResultSet.jsx
index 641cae5..14a3588 100644
--- a/superset/assets/src/SqlLab/components/ResultSet.jsx
+++ b/superset/assets/src/SqlLab/components/ResultSet.jsx
@@ -149,8 +149,9 @@ export default class ResultSet extends React.PureComponent {
+                  value={this.state.searchText}
                   className="form-control input-sm"
-                  placeholder={t('Search Results')}
+                  placeholder={t('Filter Results')}

View raw message