superset-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From johnbod...@apache.org
Subject [incubator-superset] branch master updated: [migration] Fixing issue with fb13d49b72f9 downgrade (#7145)
Date Thu, 28 Mar 2019 17:08:13 GMT
This is an automated email from the ASF dual-hosted git repository.

johnbodley pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git


The following commit(s) were added to refs/heads/master by this push:
     new 36a6fad  [migration] Fixing issue with fb13d49b72f9 downgrade (#7145)
36a6fad is described below

commit 36a6fade908510429f41d2c6831c44faed565e88
Author: John Bodley <4567245+john-bodley@users.noreply.github.com>
AuthorDate: Thu Mar 28 10:07:55 2019 -0700

    [migration] Fixing issue with fb13d49b72f9 downgrade (#7145)
    
    * [migration] Fixing issue with fb13d49b72f9 downgrade
    
    This PR fixes an issue with the downgrade step of migration fb13d49b72f9 which wrongfully
labeled the field `metrics` rather than `metric`.
    
    to: @graceguo-supercat @michellethomas @mistercrunch
    
    * Update fb13d49b72f9_better_filters.py
---
 superset/migrations/versions/fb13d49b72f9_better_filters.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/superset/migrations/versions/fb13d49b72f9_better_filters.py b/superset/migrations/versions/fb13d49b72f9_better_filters.py
index cac42c3..9ea7880 100644
--- a/superset/migrations/versions/fb13d49b72f9_better_filters.py
+++ b/superset/migrations/versions/fb13d49b72f9_better_filters.py
@@ -94,7 +94,7 @@ def downgrade():
             flts = params.get('filter_configs')
             if not flts:
                 continue
-            params['metrics'] = [flts[0].get('metric')]
+            params['metric'] = flts[0].get('metric')
             params['groupby'] = [o.get('column') for o in flts]
             slc.params = json.dumps(params, sort_keys=True)
         except Exception as e:


Mime
View raw message