superset-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
Subject [incubator-superset] branch master updated: [bugfix] SQL Lab 'Filter Results' doesn't stick (#7104)
Date Thu, 28 Mar 2019 00:53:44 GMT
This is an automated email from the ASF dual-hosted git repository.

christine pushed a commit to branch master
in repository

The following commit(s) were added to refs/heads/master by this push:
     new d5e8d66  [bugfix] SQL Lab 'Filter Results' doesn't stick (#7104)
d5e8d66 is described below

commit d5e8d663dc63ee9b99b3e7bb4e91512fa32ed1e0
Author: Maxime Beauchemin <>
AuthorDate: Wed Mar 27 17:53:32 2019 -0700

    [bugfix] SQL Lab 'Filter Results' doesn't stick (#7104)
    When using a "Search Results" criteria, the subset of rows that match
    the criteria get displayed. While this the filter is applied, if another
    query is run, the filter is still active, but not displayed in the input
    text box. After this change, the state of the input box sticks after
    subsequent queries.
 superset/assets/src/SqlLab/components/ResultSet.jsx | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/superset/assets/src/SqlLab/components/ResultSet.jsx b/superset/assets/src/SqlLab/components/ResultSet.jsx
index 12dfca7..2e8c1d0 100644
--- a/superset/assets/src/SqlLab/components/ResultSet.jsx
+++ b/superset/assets/src/SqlLab/components/ResultSet.jsx
@@ -153,8 +153,9 @@ export default class ResultSet extends React.PureComponent {
+                  value={this.state.searchText}
                   className="form-control input-sm"
-                  placeholder={t('Search Results')}
+                  placeholder={t('Filter Results')}

View raw message