From commits-return-2245-archive-asf-public=cust-asf.ponee.io@superset.incubator.apache.org Wed Feb 6 23:41:28 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 17B76180679 for ; Thu, 7 Feb 2019 00:41:27 +0100 (CET) Received: (qmail 43839 invoked by uid 500); 6 Feb 2019 23:41:27 -0000 Mailing-List: contact commits-help@superset.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@superset.incubator.apache.org Delivered-To: mailing list commits@superset.incubator.apache.org Received: (qmail 43830 invoked by uid 99); 6 Feb 2019 23:41:27 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 06 Feb 2019 23:41:27 +0000 Received: by gitbox.apache.org (ASF Mail Server at gitbox.apache.org, from userid 33) id A249D807D4; Wed, 6 Feb 2019 23:41:26 +0000 (UTC) Date: Wed, 06 Feb 2019 23:41:26 +0000 To: "commits@superset.apache.org" Subject: [incubator-superset] branch master updated: Make the target path of the superset logo configuable (#6815) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Message-ID: <154949648623.2573.9164289349137297169@gitbox.apache.org> From: christine@apache.org X-Git-Host: gitbox.apache.org X-Git-Repo: incubator-superset X-Git-Refname: refs/heads/master X-Git-Reftype: branch X-Git-Oldrev: 8041b63af647e625d6b8f0f8f109ed142e405718 X-Git-Newrev: 231d82675771ae74dbdae5322fdeb76a8e18e1b4 X-Git-Rev: 231d82675771ae74dbdae5322fdeb76a8e18e1b4 X-Git-NotificationType: ref_changed_plus_diff X-Git-Multimail-Version: 1.5.dev Auto-Submitted: auto-generated This is an automated email from the ASF dual-hosted git repository. christine pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-superset.git The following commit(s) were added to refs/heads/master by this push: new 231d826 Make the target path of the superset logo configuable (#6815) 231d826 is described below commit 231d82675771ae74dbdae5322fdeb76a8e18e1b4 Author: Christine Chambers AuthorDate: Wed Feb 6 15:41:19 2019 -0800 Make the target path of the superset logo configuable (#6815) * Make the target path of the superset logo configuable There is a need to have the target path of the logo go to different places in different installations of superset. The PR makes the target path (after `/superset`) configurable via the LOGO_TARGET_PATH configuration key and sets the default to the existing `/profile/{{ current_user.username }}/` * addressing pr comments --- superset/config.py | 4 ++++ superset/templates/appbuilder/navbar.html | 3 ++- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/superset/config.py b/superset/config.py index 31bede6..5e46c5f 100644 --- a/superset/config.py +++ b/superset/config.py @@ -112,6 +112,10 @@ APP_NAME = 'Superset' APP_ICON = '/static/assets/images/superset-logo@2x.png' APP_ICON_WIDTH = 126 +# Uncomment to specify where clicking the logo would take the user +# e.g. setting it to '/welcome' would take the user to '/superset/welcome' +LOGO_TARGET_PATH = None + # Druid query timezone # tz.tzutc() : Using utc timezone # tz.tzlocal() : Using local timezone diff --git a/superset/templates/appbuilder/navbar.html b/superset/templates/appbuilder/navbar.html index 88f4919..b5cfc64 100644 --- a/superset/templates/appbuilder/navbar.html +++ b/superset/templates/appbuilder/navbar.html @@ -20,6 +20,7 @@ {% set languages = appbuilder.languages %} {% set WARNING_MSG = appbuilder.app.config.get('WARNING_MSG') %} {% set app_icon_width = appbuilder.app.config.get('APP_ICON_WIDTH', 126) %} +{% set logo_target_path = appbuilder.app.config.get('LOGO_TARGET_PATH') or '/profile/{}/'.format(current_user.username) %}