superset-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From maximebeauche...@apache.org
Subject [incubator-superset] branch master updated: [datasource editor] Add description and label fields (#6927)
Date Mon, 25 Feb 2019 22:21:49 GMT
This is an automated email from the ASF dual-hosted git repository.

maximebeauchemin pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git


The following commit(s) were added to refs/heads/master by this push:
     new a0402b7  [datasource editor] Add description and label fields (#6927)
a0402b7 is described below

commit a0402b76c798d4eae9e070157f4a79a0510073dc
Author: Jack Zhang <moonboots08@gmail.com>
AuthorDate: Mon Feb 25 14:21:41 2019 -0800

    [datasource editor] Add description and label fields (#6927)
    
    * Add description field for columns
    
    * Add label for metrics
---
 superset/assets/src/datasource/DatasourceEditor.jsx | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/superset/assets/src/datasource/DatasourceEditor.jsx b/superset/assets/src/datasource/DatasourceEditor.jsx
index 0d8a1f8..60628d9 100644
--- a/superset/assets/src/datasource/DatasourceEditor.jsx
+++ b/superset/assets/src/datasource/DatasourceEditor.jsx
@@ -83,6 +83,11 @@ function ColumnCollectionTable({
               label={t('Label')}
               control={<TextControl />}
             />
+            <Field
+              fieldKey="description"
+              label={t('Description')}
+              control={<TextControl />}
+            />
             {allowEditDataType &&
               <Field
                 fieldKey="type"
@@ -511,6 +516,11 @@ export class DatasourceEditor extends React.PureComponent {
           <FormContainer>
             <Fieldset>
               <Field
+                fieldKey="verbose_name"
+                label={t('Label')}
+                control={<TextControl />}
+              />
+              <Field
                 fieldKey="description"
                 label={t('Description')}
                 control={<TextControl />}


Mime
View raw message