superset-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From michel...@apache.org
Subject [incubator-superset] 01/02: [bugfix] show results in query history & revert #5848 (#6436)
Date Mon, 14 Jan 2019 23:48:59 GMT
This is an automated email from the ASF dual-hosted git repository.

michellet pushed a commit to branch 0.30
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git

commit b9bcbb4f56d65172c1b9944b8f086779f4a7800d
Author: Junda Yang <youngyjd@gmail.com>
AuthorDate: Sun Jan 13 22:31:27 2019 -0800

    [bugfix] show results in query history & revert #5848 (#6436)
    
    * revert 848
    
    * nit
    
    (cherry picked from commit b1dbd1cab64d0f18146026e49769f0dec073258a)
---
 superset/assets/src/SqlLab/components/QueryAutoRefresh.jsx | 2 +-
 superset/assets/src/SqlLab/constants.js                    | 1 -
 superset/assets/src/SqlLab/reducers/sqlLab.js              | 2 +-
 3 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/superset/assets/src/SqlLab/components/QueryAutoRefresh.jsx b/superset/assets/src/SqlLab/components/QueryAutoRefresh.jsx
index 295c32f..1e9fe05 100644
--- a/superset/assets/src/SqlLab/components/QueryAutoRefresh.jsx
+++ b/superset/assets/src/SqlLab/components/QueryAutoRefresh.jsx
@@ -26,7 +26,7 @@ class QueryAutoRefresh extends React.PureComponent {
     return (
       queriesLastUpdate > 0 &&
       Object.values(queries).some(
-        q => ['running', 'started', 'pending', 'fetching', 'rendering'].indexOf(q.state)
>= 0 &&
+        q => ['running', 'started', 'pending', 'fetching'].indexOf(q.state) >= 0 &&
         now - q.startDttm < MAX_QUERY_AGE_TO_POLL,
       )
     );
diff --git a/superset/assets/src/SqlLab/constants.js b/superset/assets/src/SqlLab/constants.js
index 1e98aa0..b8d25cb 100644
--- a/superset/assets/src/SqlLab/constants.js
+++ b/superset/assets/src/SqlLab/constants.js
@@ -5,7 +5,6 @@ export const STATE_BSSTYLE_MAP = {
   fetching: 'info',
   running: 'warning',
   stopped: 'danger',
-  rendering: 'info',
   success: 'success',
 };
 
diff --git a/superset/assets/src/SqlLab/reducers/sqlLab.js b/superset/assets/src/SqlLab/reducers/sqlLab.js
index ff881c3..71d3d7b 100644
--- a/superset/assets/src/SqlLab/reducers/sqlLab.js
+++ b/superset/assets/src/SqlLab/reducers/sqlLab.js
@@ -164,7 +164,7 @@ export default function sqlLabReducer(state = {}, action) {
         progress: 100,
         results: action.results,
         rows,
-        state: 'rendering',
+        state: 'success',
         errorMessage: null,
         cached: false,
       };


Mime
View raw message