superset-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From johnbod...@apache.org
Subject [incubator-superset] 40/43: fixed ts test
Date Fri, 11 Jan 2019 02:22:44 GMT
This is an automated email from the ASF dual-hosted git repository.

johnbodley pushed a commit to branch feature--embeddable-charts-pilot
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git

commit a9b2c52f2391cc3e3433a97997a1a197ddb6af2a
Author: Conglei Shi <conglei.shi@airbnb.com>
AuthorDate: Mon Dec 17 16:16:15 2018 -0800

    fixed ts test
---
 .../assets/spec/javascripts/superset-ui/WordCloudBuildQuery.test.ts    | 3 ++-
 superset/assets/src/visualizations/wordcloud/FormData.ts               | 2 +-
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/superset/assets/spec/javascripts/superset-ui/WordCloudBuildQuery.test.ts b/superset/assets/spec/javascripts/superset-ui/WordCloudBuildQuery.test.ts
index a6edfbc..e47e042 100644
--- a/superset/assets/spec/javascripts/superset-ui/WordCloudBuildQuery.test.ts
+++ b/superset/assets/spec/javascripts/superset-ui/WordCloudBuildQuery.test.ts
@@ -3,8 +3,9 @@ import buildQuery from 'src/visualizations/wordcloud/buildQuery';
 describe('WordCloud buildQuery', () => {
   const formData = {
     datasource: '5__table',
-    granularity_sqla: 'ds',
+    granularity: 'ds',
     series: 'foo',
+    metric: 'simpleMetric',
   };
 
   it('should build groupby with series in form data', () => {
diff --git a/superset/assets/src/visualizations/wordcloud/FormData.ts b/superset/assets/src/visualizations/wordcloud/FormData.ts
index a2f85ea..dafabc6 100644
--- a/superset/assets/src/visualizations/wordcloud/FormData.ts
+++ b/superset/assets/src/visualizations/wordcloud/FormData.ts
@@ -4,7 +4,7 @@ import { FormData as GenericFormData } from 'src/query';
 interface WordCloudFormData {
   series: string;
   metric: string;
-  time_range: string;
+  time_range?: string;
 }
 
 // FormData for wordcloud contains both common properties of all form data


Mime
View raw message