superset-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From johnbod...@apache.org
Subject [incubator-superset] 09/43: fix lint
Date Fri, 11 Jan 2019 02:22:13 GMT
This is an automated email from the ASF dual-hosted git repository.

johnbodley pushed a commit to branch feature--embeddable-charts-pilot
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git

commit d826382d418e9c4cc7b5092326d66fbeda5bc439
Author: Conglei Shi <conglei.shi@airbnb.com>
AuthorDate: Wed Nov 14 23:06:24 2018 -0800

    fix lint
---
 superset/common/query_context.py |  2 +-
 superset/common/query_object.py  | 12 ++++++------
 2 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/superset/common/query_context.py b/superset/common/query_context.py
index 8a26903..b43db37 100644
--- a/superset/common/query_context.py
+++ b/superset/common/query_context.py
@@ -1,5 +1,5 @@
 # pylint: disable=R
-from typing import Dict, List,
+from typing import Dict, List
 
 from superset import db
 from superset.connectors.connector_registry import ConnectorRegistry
diff --git a/superset/common/query_object.py b/superset/common/query_object.py
index ce2685e..6ade4f0 100644
--- a/superset/common/query_object.py
+++ b/superset/common/query_object.py
@@ -1,11 +1,11 @@
 # pylint: disable=R
-import hashlib
-import simplejson as json
-
 from typing import Dict, List, Optional
 from superset import app
 from superset.utils import core as utils
 
+import hashlib
+import simplejson as json
+
 
 # TODO: Type Metrics dictionary with TypedDict when it becomes a vanilla python type
 # https://github.com/python/mypy/issues/5288
@@ -33,9 +33,9 @@ class QueryObject:
         self.granularity = granularity
         self.from_dttm, self.to_dttm = utils.get_since_until(time_range, time_shift)
         self.is_timeseries = is_timeseries
-        self.groupby = groupby or []
-        self.metrics = metrics or []
-        self.filter = filters or []
+        self.time_range =  time_range
+        self.groupby = groupby
+        self.metrics = metrics
         self.row_limit = row_limit
         self.timeseries_limit = int(limit)
         self.timeseries_limit_metric = timeseries_limit_metric


Mime
View raw message