superset-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From h...@apache.org
Subject [incubator-superset] branch omnibar updated: trying to position he omnibar
Date Wed, 23 Jan 2019 01:01:41 GMT
This is an automated email from the ASF dual-hosted git repository.

hugh pushed a commit to branch omnibar
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git


The following commit(s) were added to refs/heads/omnibar by this push:
     new af50bd5  trying to position he omnibar
af50bd5 is described below

commit af50bd58f77d6c7a9150d35026471886029e00c4
Author: hughhhh <hmiles@lyft.com>
AuthorDate: Tue Jan 22 17:01:27 2019 -0800

    trying to position he omnibar
---
 superset/assets/src/dashboard/components/Dashboard.jsx        | 11 ++++++++++-
 superset/assets/src/dashboard/components/DashboardBuilder.jsx |  3 ---
 2 files changed, 10 insertions(+), 4 deletions(-)

diff --git a/superset/assets/src/dashboard/components/Dashboard.jsx b/superset/assets/src/dashboard/components/Dashboard.jsx
index 1ada086..832e341 100644
--- a/superset/assets/src/dashboard/components/Dashboard.jsx
+++ b/superset/assets/src/dashboard/components/Dashboard.jsx
@@ -40,6 +40,8 @@ import {
   LOG_ACTIONS_FIRST_DASHBOARD_LOAD,
 } from '../../logger';
 
+import OmniContianer from '../../components/OmniContainer';
+
 import '../stylesheets/index.less';
 
 const propTypes = {
@@ -232,7 +234,14 @@ class Dashboard extends React.PureComponent {
   }
 
   render() {
-    return <DashboardBuilder />;
+    return <div style={{display: "flex"}}>
+      <div>
+      <DashboardBuilder />
+      </div>
+      <div style={{ paddingBottom: 500, zValue: -1, backgroundColor: 'black' }}>
+        <OmniContianer />
+      </div>
+    </div>;
   }
 }
 
diff --git a/superset/assets/src/dashboard/components/DashboardBuilder.jsx b/superset/assets/src/dashboard/components/DashboardBuilder.jsx
index 0c83097..75eff71 100644
--- a/superset/assets/src/dashboard/components/DashboardBuilder.jsx
+++ b/superset/assets/src/dashboard/components/DashboardBuilder.jsx
@@ -117,9 +117,6 @@ class DashboardBuilder extends React.Component {
       <StickyContainer
         className={cx('dashboard', editMode && 'dashboard--editing')}
       >
-      <div style={{paddingBottom: 500}}>
-      <OmniContianer/>
-      </div>
         <Sticky>
           {({ style }) => (
             <DragDroppable


Mime
View raw message