superset-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From maximebeauche...@apache.org
Subject [incubator-superset] branch master updated: Fix link to SQLAlchemy docs about database URLs format (#6698)
Date Sat, 19 Jan 2019 06:32:35 GMT
This is an automated email from the ASF dual-hosted git repository.

maximebeauchemin pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git


The following commit(s) were added to refs/heads/master by this push:
     new 01063ce  Fix link to SQLAlchemy docs about database URLs format (#6698)
01063ce is described below

commit 01063ce96c56cee0a54629fb1a0fed813b4609ae
Author: Andrew Kovalyov <akovalyov@users.noreply.github.com>
AuthorDate: Sat Jan 19 08:32:29 2019 +0200

    Fix link to SQLAlchemy docs about database URLs format (#6698)
    
    'Add database' grid refers to SQLAchemy docs, where database URL format is described.
    Documentation for 1.0 does not exist on https://docs.sqlalchemy.org/, which results in
404 when following the current URL.
    The link is fixed taking into account [SQLAlchemy 1.2](https://github.com/apache/incubator-superset/blob/master/requirements.txt#L87)
as a project dependency.
---
 superset/views/core.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/superset/views/core.py b/superset/views/core.py
index 02ff66a..f7672f6 100755
--- a/superset/views/core.py
+++ b/superset/views/core.py
@@ -187,7 +187,7 @@ class DatabaseView(SupersetModelView, DeleteMixin, YamlExportMixin): 
# noqa
         'sqlalchemy_uri': utils.markdown(
             'Refer to the '
             '[SqlAlchemy docs]'
-            '(http://docs.sqlalchemy.org/en/rel_1_0/core/engines.html#'
+            '(http://docs.sqlalchemy.org/en/rel_1_2/core/engines.html#'
             'database-urls) '
             'for more information on how to structure your URI.', True),
         'expose_in_sqllab': _('Expose this DB in SQL Lab'),


Mime
View raw message