superset-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From maximebeauche...@apache.org
Subject [incubator-superset] branch master updated: Remove dep on unidecode (#6673)
Date Sun, 13 Jan 2019 17:22:24 GMT
This is an automated email from the ASF dual-hosted git repository.

maximebeauchemin pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git


The following commit(s) were added to refs/heads/master by this push:
     new ae6217b  Remove dep on unidecode (#6673)
ae6217b is described below

commit ae6217ba5500c55f19a71b678dfc468c144c6492
Author: Maxime Beauchemin <maximebeauchemin@gmail.com>
AuthorDate: Sun Jan 13 09:22:13 2019 -0800

    Remove dep on unidecode (#6673)
    
    Not needed anymore in py3
---
 requirements.txt       | 1 -
 setup.py               | 1 -
 superset/views/core.py | 4 +---
 3 files changed, 1 insertion(+), 5 deletions(-)

diff --git a/requirements.txt b/requirements.txt
index 838cb6d..c503e27 100644
--- a/requirements.txt
+++ b/requirements.txt
@@ -92,7 +92,6 @@ thrift-sasl==0.3.0
 thrift==0.11.0
 tornado==5.1.1            # via flower
 unicodecsv==0.14.1
-unidecode==1.0.22
 urllib3==1.22             # via requests, selenium
 vine==1.1.4               # via amqp
 webencodings==0.5.1       # via bleach
diff --git a/setup.py b/setup.py
index 236298f..4207f21 100644
--- a/setup.py
+++ b/setup.py
@@ -94,7 +94,6 @@ setup(
         'thrift>=0.9.3',
         'thrift-sasl>=0.2.1',
         'unicodecsv',
-        'unidecode>=0.04.21',
     ],
     extras_require={
         'cors': ['flask-cors>=2.0.0'],
diff --git a/superset/views/core.py b/superset/views/core.py
index 3c3737a..e8b1859 100755
--- a/superset/views/core.py
+++ b/superset/views/core.py
@@ -23,7 +23,6 @@ import sqlalchemy as sqla
 from sqlalchemy import and_, create_engine, MetaData, or_, update
 from sqlalchemy.engine.url import make_url
 from sqlalchemy.exc import IntegrityError
-from unidecode import unidecode
 from werkzeug.routing import BaseConverter
 from werkzeug.utils import secure_filename
 
@@ -2614,8 +2613,7 @@ class Superset(BaseSupersetView):
             # TODO(bkyryliuk): add compression=gzip for big files.
             csv = df.to_csv(index=False, **config.get('CSV_EXPORT'))
         response = Response(csv, mimetype='text/csv')
-        response.headers['Content-Disposition'] = (
-            'attachment; filename={}.csv'.format(unidecode(query.name)))
+        response.headers['Content-Disposition'] = f'attachment; filename={query.name}.csv'
         logging.info('Ready to return response')
         return response
 


Mime
View raw message