superset-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [incubator-superset] Diff for: [GitHub] mistercrunch closed pull request #6673: Remove dep on unidecode
Date Sun, 13 Jan 2019 17:22:15 GMT
diff --git a/requirements.txt b/requirements.txt
index 838cb6d04f..c503e2712a 100644
--- a/requirements.txt
+++ b/requirements.txt
@@ -92,7 +92,6 @@ thrift-sasl==0.3.0
 thrift==0.11.0
 tornado==5.1.1            # via flower
 unicodecsv==0.14.1
-unidecode==1.0.22
 urllib3==1.22             # via requests, selenium
 vine==1.1.4               # via amqp
 webencodings==0.5.1       # via bleach
diff --git a/setup.py b/setup.py
index 236298f60e..4207f21080 100644
--- a/setup.py
+++ b/setup.py
@@ -94,7 +94,6 @@ def get_git_sha():
         'thrift>=0.9.3',
         'thrift-sasl>=0.2.1',
         'unicodecsv',
-        'unidecode>=0.04.21',
     ],
     extras_require={
         'cors': ['flask-cors>=2.0.0'],
diff --git a/superset/views/core.py b/superset/views/core.py
index 3c3737a01d..e8b1859c1a 100755
--- a/superset/views/core.py
+++ b/superset/views/core.py
@@ -23,7 +23,6 @@
 from sqlalchemy import and_, create_engine, MetaData, or_, update
 from sqlalchemy.engine.url import make_url
 from sqlalchemy.exc import IntegrityError
-from unidecode import unidecode
 from werkzeug.routing import BaseConverter
 from werkzeug.utils import secure_filename
 
@@ -2614,8 +2613,7 @@ def csv(self, client_id):
             # TODO(bkyryliuk): add compression=gzip for big files.
             csv = df.to_csv(index=False, **config.get('CSV_EXPORT'))
         response = Response(csv, mimetype='text/csv')
-        response.headers['Content-Disposition'] = (
-            'attachment; filename={}.csv'.format(unidecode(query.name)))
+        response.headers['Content-Disposition'] = f'attachment; filename={query.name}.csv'
         logging.info('Ready to return response')
         return response
 


With regards,
Apache Git Services

Mime
View raw message