superset-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From michel...@apache.org
Subject [incubator-superset] branch master updated: Fixing error when clearing big number (#6465)
Date Fri, 30 Nov 2018 02:52:55 GMT
This is an automated email from the ASF dual-hosted git repository.

michellet pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git


The following commit(s) were added to refs/heads/master by this push:
     new 5261d8a  Fixing error when clearing big number (#6465)
5261d8a is described below

commit 5261d8a9fe488632ece8d1f4993088b9eb966e67
Author: michellethomas <michelle.q.thomas@gmail.com>
AuthorDate: Thu Nov 29 18:52:49 2018 -0800

    Fixing error when clearing big number (#6465)
---
 superset/assets/src/visualizations/BigNumber/transformProps.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/superset/assets/src/visualizations/BigNumber/transformProps.js b/superset/assets/src/visualizations/BigNumber/transformProps.js
index a046da3..92a88f3 100644
--- a/superset/assets/src/visualizations/BigNumber/transformProps.js
+++ b/superset/assets/src/visualizations/BigNumber/transformProps.js
@@ -28,7 +28,7 @@ export default function transformProps(chartProps) {
 
   let bigNumber;
   let trendLineData;
-  const metricName = metric.label || metric;
+  const metricName = metric && metric.label ? metric.label : metric;
   const compareLag = +compareLagInput || 0;
   const supportTrendLine = vizType === 'big_number';
   const supportAndShowTrendLine = supportTrendLine && showTrendLine;


Mime
View raw message