superset-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From grace...@apache.org
Subject [incubator-superset] branch master updated: [logging] Add render failure error into log (#6422)
Date Mon, 26 Nov 2018 19:51:30 GMT
This is an automated email from the ASF dual-hosted git repository.

graceguo pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git


The following commit(s) were added to refs/heads/master by this push:
     new 2489876  [logging] Add render failure error into log (#6422)
2489876 is described below

commit 2489876bc94078be5471658ca229117bf2346586
Author: Grace Guo <grace.guo@airbnb.com>
AuthorDate: Mon Nov 26 11:51:25 2018 -0800

    [logging] Add render failure error into log (#6422)
---
 superset/assets/src/chart/Chart.jsx | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/superset/assets/src/chart/Chart.jsx b/superset/assets/src/chart/Chart.jsx
index 2a35fbe..77f91b1 100644
--- a/superset/assets/src/chart/Chart.jsx
+++ b/superset/assets/src/chart/Chart.jsx
@@ -95,6 +95,14 @@ class Chart extends React.PureComponent {
     const { actions, chartId } = this.props;
     console.warn(error); // eslint-disable-line
     actions.chartRenderingFailed(error.toString(), chartId, info ? info.componentStack :
null);
+
+    Logger.append(LOG_ACTIONS_RENDER_CHART, {
+      slice_id: chartId,
+      has_err: true,
+      error_details: error.toString(),
+      start_offset: this.renderStartTime,
+      duration: Logger.getTimestamp() - this.renderStartTime,
+    });
   }
 
   prepareChartProps() {


Mime
View raw message