superset-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From maximebeauche...@apache.org
Subject [incubator-superset] branch master updated: [bugfix] handle Loading spinner properly (#6292)
Date Wed, 07 Nov 2018 21:04:24 GMT
This is an automated email from the ASF dual-hosted git repository.

maximebeauchemin pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git


The following commit(s) were added to refs/heads/master by this push:
     new aed774e  [bugfix] handle Loading spinner properly (#6292)
aed774e is described below

commit aed774e18b26c737c0ba58d9b203a8d4a9840614
Author: Maxime Beauchemin <maximebeauchemin@gmail.com>
AuthorDate: Wed Nov 7 13:04:17 2018 -0800

    [bugfix] handle Loading spinner properly (#6292)
    
    Addressing post-merge comments in
    https://github.com/apache/incubator-superset/pull/6283
---
 superset/assets/src/chart/Chart.jsx | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/superset/assets/src/chart/Chart.jsx b/superset/assets/src/chart/Chart.jsx
index b6bc8d7..a4be8dc 100644
--- a/superset/assets/src/chart/Chart.jsx
+++ b/superset/assets/src/chart/Chart.jsx
@@ -176,7 +176,7 @@ class Chart extends React.PureComponent {
       >
         {this.renderTooltip()}
 
-        {chartStatus !== 'rendered' && <Loading size={50} />}
+        {['loading', 'success'].indexOf(chartStatus) >= 0 && <Loading size={50}
/>}
 
         {chartAlert && (
           <StackTraceMessage


Mime
View raw message