superset-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From maximebeauche...@apache.org
Subject [incubator-superset] branch master updated: [dashboard] fix spinners disapear too early (#6283)
Date Tue, 06 Nov 2018 16:51:42 GMT
This is an automated email from the ASF dual-hosted git repository.

maximebeauchemin pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git


The following commit(s) were added to refs/heads/master by this push:
     new a1d867c  [dashboard] fix spinners disapear too early (#6283)
a1d867c is described below

commit a1d867cf2f3e519c454cd33d60b9772f9c7551e2
Author: Maxime Beauchemin <maximebeauchemin@gmail.com>
AuthorDate: Tue Nov 6 08:51:36 2018 -0800

    [dashboard] fix spinners disapear too early (#6283)
    
    Recently I noticed that loading spinners on dashboards would disappear
    too early.
---
 superset/assets/src/chart/Chart.jsx | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/superset/assets/src/chart/Chart.jsx b/superset/assets/src/chart/Chart.jsx
index 5988b4f..b6bc8d7 100644
--- a/superset/assets/src/chart/Chart.jsx
+++ b/superset/assets/src/chart/Chart.jsx
@@ -176,7 +176,7 @@ class Chart extends React.PureComponent {
       >
         {this.renderTooltip()}
 
-        {isLoading && <Loading size={50} />}
+        {chartStatus !== 'rendered' && <Loading size={50} />}
 
         {chartAlert && (
           <StackTraceMessage


Mime
View raw message