superset-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ccwilli...@apache.org
Subject [incubator-superset] 01/01: [cypress][sqllab] increase timeout for sqllab results
Date Fri, 12 Oct 2018 17:48:44 GMT
This is an automated email from the ASF dual-hosted git repository.

ccwilliams pushed a commit to branch chris--fix-flaky-cypress-sqllab
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git

commit 650f75d0698da3e215d0f4221ebfacc3947470f8
Author: Chris Williams <chris.williams@airbnb.com>
AuthorDate: Fri Oct 12 10:48:28 2018 -0700

    [cypress][sqllab] increase timeout for sqllab results
---
 superset/assets/cypress/integration/sqllab/query.js         | 2 +-
 superset/assets/cypress/integration/sqllab/sqllab.helper.js | 3 ++-
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/superset/assets/cypress/integration/sqllab/query.js b/superset/assets/cypress/integration/sqllab/query.js
index 2f799b0..0f52039 100644
--- a/superset/assets/cypress/integration/sqllab/query.js
+++ b/superset/assets/cypress/integration/sqllab/query.js
@@ -26,7 +26,7 @@ export default () => {
 
       cy.wait('@sqlLabQuery');
 
-      cy.get('.SouthPane .ReactVirtualized__Table')
+      selectResultsTab()
         .eq(0) // ensures results tab in case preview tab exists
         .then((tableNodes) => {
           const [header, bodyWrapper] = tableNodes[0].childNodes;
diff --git a/superset/assets/cypress/integration/sqllab/sqllab.helper.js b/superset/assets/cypress/integration/sqllab/sqllab.helper.js
index 7c28b5f..e366661 100644
--- a/superset/assets/cypress/integration/sqllab/sqllab.helper.js
+++ b/superset/assets/cypress/integration/sqllab/sqllab.helper.js
@@ -1,4 +1,5 @@
-export const selectResultsTab = () => cy.get('.SouthPane .ReactVirtualized__Table');
+export const selectResultsTab = () =>
+  cy.get('.SouthPane .ReactVirtualized__Table', { timeout: 10000 });
 
 // this function asserts that the result set for two SQL lab table results are equal
 export const assertSQLLabResultsAreEqual = (resultsA, resultsB) => {


Mime
View raw message