superset-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From maximebeauche...@apache.org
Subject [incubator-superset] branch master updated: [bugfix] cannot add options to FilterBox (#6231)
Date Wed, 31 Oct 2018 05:00:07 GMT
This is an automated email from the ASF dual-hosted git repository.

maximebeauchemin pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git


The following commit(s) were added to refs/heads/master by this push:
     new af38d25  [bugfix] cannot add options to FilterBox (#6231)
af38d25 is described below

commit af38d254f0022af6a0282d02e610d3721aff4007
Author: Maxime Beauchemin <maximebeauchemin@gmail.com>
AuthorDate: Tue Oct 30 21:59:57 2018 -0700

    [bugfix] cannot add options to FilterBox (#6231)
    
    * [bugfix] cannot add options to FilterBox
    
    * addressing comments
---
 superset/assets/src/visualizations/FilterBox/FilterBox.jsx | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/superset/assets/src/visualizations/FilterBox/FilterBox.jsx b/superset/assets/src/visualizations/FilterBox/FilterBox.jsx
index 05b9c9f..aa4071e 100644
--- a/superset/assets/src/visualizations/FilterBox/FilterBox.jsx
+++ b/superset/assets/src/visualizations/FilterBox/FilterBox.jsx
@@ -178,8 +178,7 @@ class FilterBox extends React.Component {
     // Add created options to filtersChoices, even though it doesn't exist,
     // or these options will exist in query sql but invisible to end user.
     Object.keys(selectedValues)
-      .filter(key => !selectedValues.hasOwnProperty(key)
-        || !(key in filtersChoices))
+      .filter(key => selectedValues.hasOwnProperty(key) && (key in filtersChoices))
       .forEach((key) => {
         const choices = filtersChoices[key] || [];
         const choiceIds = new Set(choices.map(f => f.id));


Mime
View raw message