superset-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From maximebeauche...@apache.org
Subject [incubator-superset] branch master updated: fix for annotation layer bug (#6047)
Date Sun, 07 Oct 2018 19:35:43 GMT
This is an automated email from the ASF dual-hosted git repository.

maximebeauchemin pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git


The following commit(s) were added to refs/heads/master by this push:
     new 06e029f  fix for annotation layer bug (#6047)
06e029f is described below

commit 06e029f9d3756218303efba2c4d7a6b9e5c30403
Author: Yuguang Zhang <zh.yuguang.cn@gmail.com>
AuthorDate: Sun Oct 7 12:35:36 2018 -0700

    fix for annotation layer bug (#6047)
---
 superset/assets/src/explore/components/controls/AnnotationLayer.jsx | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/superset/assets/src/explore/components/controls/AnnotationLayer.jsx b/superset/assets/src/explore/components/controls/AnnotationLayer.jsx
index 3238f4f..d37743c 100644
--- a/superset/assets/src/explore/components/controls/AnnotationLayer.jsx
+++ b/superset/assets/src/explore/components/controls/AnnotationLayer.jsx
@@ -279,7 +279,7 @@ export default class AnnotationLayer extends React.PureComponent {
         description = `Use a pre defined Superset Chart as a source for annotations and overlays.
         'your chart must be one of these visualization types:
         '[${getSupportedSourceTypes(annotationType)
-            .map(x => vizTypes[x].label).join(', ')}]'`;
+            .map(x => ((x in vizTypes && 'label' in vizTypes[x]) ? vizTypes[x].label
: '')).join(', ')}]'`;
       }
     } else if (annotationType === AnnotationTypes.FORMULA) {
       label = t('Formula');


Mime
View raw message