From commits-return-1488-archive-asf-public=cust-asf.ponee.io@superset.incubator.apache.org Tue Sep 11 17:11:35 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 0E54518065B for ; Tue, 11 Sep 2018 17:11:34 +0200 (CEST) Received: (qmail 88291 invoked by uid 500); 11 Sep 2018 15:07:13 -0000 Mailing-List: contact commits-help@superset.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@superset.incubator.apache.org Delivered-To: mailing list commits@superset.incubator.apache.org Received: (qmail 61871 invoked by uid 99); 11 Sep 2018 15:06:27 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 11 Sep 2018 15:06:27 +0000 Received: by gitbox.apache.org (ASF Mail Server at gitbox.apache.org, from userid 33) id C24CF8513C; Tue, 11 Sep 2018 15:06:23 +0000 (UTC) Date: Tue, 11 Sep 2018 15:06:23 +0000 To: "commits@superset.apache.org" Subject: [incubator-superset] branch master updated: [bugfix] fix rows not showing on welcome page (retry) (#5849) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Message-ID: <153667838354.1210.9172874939900793357@gitbox.apache.org> From: graceguo@apache.org X-Git-Host: gitbox.apache.org X-Git-Repo: incubator-superset X-Git-Refname: refs/heads/master X-Git-Reftype: branch X-Git-Oldrev: 73cfcccf050d71f13edc88b330ef6433ebad7ff4 X-Git-Newrev: ce362f0ad6a60e1c7d12f1689d3661fdf6e0ac83 X-Git-Rev: ce362f0ad6a60e1c7d12f1689d3661fdf6e0ac83 X-Git-NotificationType: ref_changed_plus_diff X-Git-Multimail-Version: 1.5.dev Auto-Submitted: auto-generated This is an automated email from the ASF dual-hosted git repository. graceguo pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-superset.git The following commit(s) were added to refs/heads/master by this push: new ce362f0 [bugfix] fix rows not showing on welcome page (retry) (#5849) ce362f0 is described below commit ce362f0ad6a60e1c7d12f1689d3661fdf6e0ac83 Author: Krist Wongsuphasawat AuthorDate: Tue Sep 11 08:06:18 2018 -0700 [bugfix] fix rows not showing on welcome page (retry) (#5849) * fix rows not showing on welcome page * remove test code * bring filter back * remove empty line * remove another empty line * remove comment --- superset/assets/package.json | 2 +- superset/assets/src/welcome/App.jsx | 1 - superset/assets/src/welcome/DashboardTable.jsx | 6 ++---- superset/assets/yarn.lock | 6 +++--- 4 files changed, 6 insertions(+), 9 deletions(-) diff --git a/superset/assets/package.json b/superset/assets/package.json index 4d137a4..667b4cb 100644 --- a/superset/assets/package.json +++ b/superset/assets/package.json @@ -115,7 +115,7 @@ "react-syntax-highlighter": "^7.0.4", "react-virtualized": "9.19.1", "react-virtualized-select": "^3.1.3", - "reactable": "1.0.2", + "reactable": "^1.1.0", "redux": "^3.5.2", "redux-localstorage": "^0.4.1", "redux-thunk": "^2.1.0", diff --git a/superset/assets/src/welcome/App.jsx b/superset/assets/src/welcome/App.jsx index 1591b52..3528345 100644 --- a/superset/assets/src/welcome/App.jsx +++ b/superset/assets/src/welcome/App.jsx @@ -1,4 +1,3 @@ -/* eslint no-unused-vars: 0 */ import React from 'react'; import { hot } from 'react-hot-loader'; import { appSetup } from '../common'; diff --git a/superset/assets/src/welcome/DashboardTable.jsx b/superset/assets/src/welcome/DashboardTable.jsx index 6b6b710..0f4c744 100644 --- a/superset/assets/src/welcome/DashboardTable.jsx +++ b/superset/assets/src/welcome/DashboardTable.jsx @@ -1,9 +1,6 @@ -/* eslint no-unused-vars: 0 */ import React from 'react'; -import ReactDOM from 'react-dom'; import PropTypes from 'prop-types'; -import { Table, Tr, Td, Thead, Th, unsafe } from 'reactable'; - +import { Table, Tr, Td, unsafe } from 'reactable'; import Loading from '../components/Loading'; import '../../stylesheets/reactable-pagination.css'; @@ -64,4 +61,5 @@ export default class DashboardTable extends React.PureComponent { return ; } } + DashboardTable.propTypes = propTypes; diff --git a/superset/assets/yarn.lock b/superset/assets/yarn.lock index 5271b82..6f04ebf 100644 --- a/superset/assets/yarn.lock +++ b/superset/assets/yarn.lock @@ -10292,9 +10292,9 @@ react@^16.4.1: prop-types "^15.6.2" schedule "^0.3.0" -reactable@1.0.2: - version "1.0.2" - resolved "https://registry.yarnpkg.com/reactable/-/reactable-1.0.2.tgz#67a579fee3af68b991b5f04df921a4a40ece0b72" +reactable@^1.1.0: + version "1.1.0" + resolved "https://registry.yarnpkg.com/reactable/-/reactable-1.1.0.tgz#2f84bb8b3808df8ac64694b539be416438db8498" reactcss@^1.2.0: version "1.2.3"