superset-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From grace...@apache.org
Subject [incubator-superset] branch master updated: wait and verify one-by-one (#5995)
Date Thu, 27 Sep 2018 21:46:58 GMT
This is an automated email from the ASF dual-hosted git repository.

graceguo pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git


The following commit(s) were added to refs/heads/master by this push:
     new 4868c00  wait and verify one-by-one (#5995)
4868c00 is described below

commit 4868c00d6dff3c6a1f790a0da0abe854005498c1
Author: Krist Wongsuphasawat <krist.wongz@gmail.com>
AuthorDate: Thu Sep 27 14:46:52 2018 -0700

    wait and verify one-by-one (#5995)
---
 superset/assets/cypress/integration/dashboard/dashboard_tests.js | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/superset/assets/cypress/integration/dashboard/dashboard_tests.js b/superset/assets/cypress/integration/dashboard/dashboard_tests.js
index ed2ac08..efe6999 100644
--- a/superset/assets/cypress/integration/dashboard/dashboard_tests.js
+++ b/superset/assets/cypress/integration/dashboard/dashboard_tests.js
@@ -15,11 +15,9 @@ describe('Load dashboard', () => {
       });
       // reload the dashboard again with all routes watched.
       cy.visit('/superset/dashboard/births');
-      // wait for all requests to complete
-      cy.wait(aliases);
-      // verify one-by-one
+      // wait and verify one-by-one
       aliases.forEach((alias) => {
-        cy.get(alias).then((xhr) => {
+        cy.wait(alias).then((xhr) => {
           expect(xhr.status).to.eq(200);
           expect(xhr.response.body).to.have.property('error', null);
           cy.get(`#slice-container-${xhr.response.body.form_data.slice_id}`);


Mime
View raw message