superset-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ccwilli...@apache.org
Subject [incubator-superset] branch master updated: Remove unused functions and jquery dependency (#5868)
Date Tue, 18 Sep 2018 16:52:55 GMT
This is an automated email from the ASF dual-hosted git repository.

ccwilliams pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git


The following commit(s) were added to refs/heads/master by this push:
     new f2d6449  Remove unused functions and jquery dependency (#5868)
f2d6449 is described below

commit f2d64492efb3d1b76bb60b9305def9d06b4d5567
Author: Krist Wongsuphasawat <krist.wongz@gmail.com>
AuthorDate: Tue Sep 18 09:52:49 2018 -0700

    Remove unused functions and jquery dependency (#5868)
    
    * remove unused functions and jquery dependency
    
    * rebase and remove more obsolete functions
---
 superset/assets/src/chart/ChartBody.jsx | 21 ---------------------
 1 file changed, 21 deletions(-)

diff --git a/superset/assets/src/chart/ChartBody.jsx b/superset/assets/src/chart/ChartBody.jsx
index b459f44..4ab7364 100644
--- a/superset/assets/src/chart/ChartBody.jsx
+++ b/superset/assets/src/chart/ChartBody.jsx
@@ -1,6 +1,5 @@
 import React from 'react';
 import PropTypes from 'prop-types';
-import $ from 'jquery';
 
 const propTypes = {
   containerId: PropTypes.string.isRequired,
@@ -11,26 +10,6 @@ const propTypes = {
 };
 
 class ChartBody extends React.PureComponent {
-  html(data) {
-    this.el.innerHTML = data;
-  }
-
-  css(property, value) {
-    this.el.style[property] = value;
-  }
-
-  get(n) {
-    return $(this.el).get(n);
-  }
-
-  find(classname) {
-    return $(this.el).find(classname);
-  }
-
-  show() {
-    return $(this.el).show();
-  }
-
   height() {
     return this.props.height();
   }


Mime
View raw message