superset-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From b...@apache.org
Subject [incubator-superset] branch master updated: [time table] fix sorting on missing values (#5863)
Date Wed, 12 Sep 2018 18:21:51 GMT
This is an automated email from the ASF dual-hosted git repository.

beto pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git


The following commit(s) were added to refs/heads/master by this push:
     new 367dcda  [time table] fix sorting on missing values (#5863)
367dcda is described below

commit 367dcdaa7de04bb281df6a59926cefa7ec1794a1
Author: Maxime Beauchemin <maximebeauchemin@gmail.com>
AuthorDate: Wed Sep 12 11:21:48 2018 -0700

    [time table] fix sorting on missing values (#5863)
---
 superset/assets/src/visualizations/time_table.jsx | 1 +
 1 file changed, 1 insertion(+)

diff --git a/superset/assets/src/visualizations/time_table.jsx b/superset/assets/src/visualizations/time_table.jsx
index c34e5d0..d2bf633 100644
--- a/superset/assets/src/visualizations/time_table.jsx
+++ b/superset/assets/src/visualizations/time_table.jsx
@@ -123,6 +123,7 @@ function viz(slice, payload) {
           } else if (column.comparisonType === 'perc_change') {
             v = (recent / v) - 1;
           }
+          v = v || 0;
         } else if (column.colType === 'contrib') {
           // contribution to column total
           v = recent / Object.keys(reversedData[0])


Mime
View raw message