superset-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From grace...@apache.org
Subject [incubator-superset] branch master updated: [bugfix] fix rows not showing on welcome page (retry) (#5849)
Date Tue, 11 Sep 2018 15:06:23 GMT
This is an automated email from the ASF dual-hosted git repository.

graceguo pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git


The following commit(s) were added to refs/heads/master by this push:
     new ce362f0  [bugfix] fix rows not showing on welcome page (retry) (#5849)
ce362f0 is described below

commit ce362f0ad6a60e1c7d12f1689d3661fdf6e0ac83
Author: Krist Wongsuphasawat <krist.wongz@gmail.com>
AuthorDate: Tue Sep 11 08:06:18 2018 -0700

    [bugfix] fix rows not showing on welcome page (retry) (#5849)
    
    * fix rows not showing on welcome page
    
    * remove test code
    
    * bring filter back
    
    * remove empty line
    
    * remove another empty line
    
    * remove comment
---
 superset/assets/package.json                   | 2 +-
 superset/assets/src/welcome/App.jsx            | 1 -
 superset/assets/src/welcome/DashboardTable.jsx | 6 ++----
 superset/assets/yarn.lock                      | 6 +++---
 4 files changed, 6 insertions(+), 9 deletions(-)

diff --git a/superset/assets/package.json b/superset/assets/package.json
index 4d137a4..667b4cb 100644
--- a/superset/assets/package.json
+++ b/superset/assets/package.json
@@ -115,7 +115,7 @@
     "react-syntax-highlighter": "^7.0.4",
     "react-virtualized": "9.19.1",
     "react-virtualized-select": "^3.1.3",
-    "reactable": "1.0.2",
+    "reactable": "^1.1.0",
     "redux": "^3.5.2",
     "redux-localstorage": "^0.4.1",
     "redux-thunk": "^2.1.0",
diff --git a/superset/assets/src/welcome/App.jsx b/superset/assets/src/welcome/App.jsx
index 1591b52..3528345 100644
--- a/superset/assets/src/welcome/App.jsx
+++ b/superset/assets/src/welcome/App.jsx
@@ -1,4 +1,3 @@
-/* eslint no-unused-vars: 0 */
 import React from 'react';
 import { hot } from 'react-hot-loader';
 import { appSetup } from '../common';
diff --git a/superset/assets/src/welcome/DashboardTable.jsx b/superset/assets/src/welcome/DashboardTable.jsx
index 6b6b710..0f4c744 100644
--- a/superset/assets/src/welcome/DashboardTable.jsx
+++ b/superset/assets/src/welcome/DashboardTable.jsx
@@ -1,9 +1,6 @@
-/* eslint no-unused-vars: 0 */
 import React from 'react';
-import ReactDOM from 'react-dom';
 import PropTypes from 'prop-types';
-import { Table, Tr, Td, Thead, Th, unsafe } from 'reactable';
-
+import { Table, Tr, Td, unsafe } from 'reactable';
 import Loading from '../components/Loading';
 import '../../stylesheets/reactable-pagination.css';
 
@@ -64,4 +61,5 @@ export default class DashboardTable extends React.PureComponent {
     return <Loading />;
   }
 }
+
 DashboardTable.propTypes = propTypes;
diff --git a/superset/assets/yarn.lock b/superset/assets/yarn.lock
index 5271b82..6f04ebf 100644
--- a/superset/assets/yarn.lock
+++ b/superset/assets/yarn.lock
@@ -10292,9 +10292,9 @@ react@^16.4.1:
     prop-types "^15.6.2"
     schedule "^0.3.0"
 
-reactable@1.0.2:
-  version "1.0.2"
-  resolved "https://registry.yarnpkg.com/reactable/-/reactable-1.0.2.tgz#67a579fee3af68b991b5f04df921a4a40ece0b72"
+reactable@^1.1.0:
+  version "1.1.0"
+  resolved "https://registry.yarnpkg.com/reactable/-/reactable-1.1.0.tgz#2f84bb8b3808df8ac64694b539be416438db8498"
 
 reactcss@^1.2.0:
   version "1.2.3"


Mime
View raw message