superset-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ccwilli...@apache.org
Subject [incubator-superset] branch master updated: [SIP-5] Remove unused function #easy-review (#5825)
Date Wed, 05 Sep 2018 20:46:07 GMT
This is an automated email from the ASF dual-hosted git repository.

ccwilliams pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git


The following commit(s) were added to refs/heads/master by this push:
     new a9952bb  [SIP-5] Remove unused function #easy-review (#5825)
a9952bb is described below

commit a9952bb4492b86192a39a669e2d35d969d56c3dd
Author: Krist Wongsuphasawat <krist.wongz@gmail.com>
AuthorDate: Wed Sep 5 13:46:04 2018 -0700

    [SIP-5] Remove unused function #easy-review (#5825)
    
    * remove unused function
    
    * remove comment
---
 superset/assets/src/chart/Chart.jsx         | 4 ----
 superset/assets/src/visualizations/table.js | 4 ----
 2 files changed, 8 deletions(-)

diff --git a/superset/assets/src/chart/Chart.jsx b/superset/assets/src/chart/Chart.jsx
index b93b275..a9dd0ff 100644
--- a/superset/assets/src/chart/Chart.jsx
+++ b/superset/assets/src/chart/Chart.jsx
@@ -170,10 +170,6 @@ class Chart extends React.PureComponent {
     this.props.actions.chartRenderingFailed(e, this.props.chartId);
   }
 
-  verboseMetricName(metric) {
-    return this.props.datasource.verbose_map[metric] || metric;
-  }
-
   renderTooltip() {
     if (this.state.tooltip) {
       return (
diff --git a/superset/assets/src/visualizations/table.js b/superset/assets/src/visualizations/table.js
index 1e09b83..a875aad 100644
--- a/superset/assets/src/visualizations/table.js
+++ b/superset/assets/src/visualizations/table.js
@@ -288,10 +288,6 @@ function adaptor(slice, payload) {
     orderDesc,
     pageLength: pageLength && parseInt(pageLength, 10),
     percentMetrics,
-    // Aug 22, 2018
-    // Perhaps this `tableFilter` field can be removed as there is
-    // no code left in repo to set tableFilter to true.
-    // which make `onAddFilter` will never be called as well.
     tableFilter,
     tableTimestampFormat,
     timeseriesLimitMetric,


Mime
View raw message