superset-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From b...@apache.org
Subject [incubator-superset] branch master updated: bug: don't show query overlay when panning mapbox maps (#5814)
Date Wed, 05 Sep 2018 01:08:04 GMT
This is an automated email from the ASF dual-hosted git repository.

beto pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git


The following commit(s) were added to refs/heads/master by this push:
     new a411516  bug: don't show query overlay when panning mapbox maps (#5814)
a411516 is described below

commit a411516ff57c73c5dfca41838ed84928dc713041
Author: Christine Chambers <christine.d.hang@gmail.com>
AuthorDate: Tue Sep 4 18:08:00 2018 -0700

    bug: don't show query overlay when panning mapbox maps (#5814)
    
    * bug: don't show query overlay when panning mapbox maps
    
    Since we don't want to prompt user to rerun query every time they pan a map, prevent the
query overlay from showing by setting dontRefreshOnChange for viewport_latitude and viewport_longitude
controls.
    
    * Prevent query overlay on viewport zoom also.
---
 superset/assets/src/explore/controls.jsx | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/superset/assets/src/explore/controls.jsx b/superset/assets/src/explore/controls.jsx
index cb46684..8c063a7 100644
--- a/superset/assets/src/explore/controls.jsx
+++ b/superset/assets/src/explore/controls.jsx
@@ -1806,6 +1806,8 @@ export const controls = {
     default: 11,
     description: t('Zoom level of the map'),
     places: 8,
+    // Viewport zoom shouldn't prompt user to re-run query
+    dontRefreshOnChange: true,
   },
 
   viewport_latitude: {
@@ -1815,6 +1817,8 @@ export const controls = {
     isFloat: true,
     description: t('Latitude of default viewport'),
     places: 8,
+    // Viewport latitude changes shouldn't prompt user to re-run query
+    dontRefreshOnChange: true,
   },
 
   viewport_longitude: {
@@ -1824,6 +1828,8 @@ export const controls = {
     isFloat: true,
     description: t('Longitude of default viewport'),
     places: 8,
+    // Viewport longitude changes shouldn't prompt user to re-run query
+    dontRefreshOnChange: true,
   },
 
   render_while_dragging: {


Mime
View raw message