From commits-return-1430-archive-asf-public=cust-asf.ponee.io@superset.incubator.apache.org Wed Aug 29 02:05:50 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id D5613180621 for ; Wed, 29 Aug 2018 02:05:49 +0200 (CEST) Received: (qmail 17673 invoked by uid 500); 29 Aug 2018 00:05:49 -0000 Mailing-List: contact commits-help@superset.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@superset.incubator.apache.org Delivered-To: mailing list commits@superset.incubator.apache.org Received: (qmail 17664 invoked by uid 99); 29 Aug 2018 00:05:49 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 29 Aug 2018 00:05:49 +0000 Received: by gitbox.apache.org (ASF Mail Server at gitbox.apache.org, from userid 33) id 77BDF82F9F; Wed, 29 Aug 2018 00:05:48 +0000 (UTC) Date: Wed, 29 Aug 2018 00:05:48 +0000 To: "commits@superset.apache.org" Subject: [incubator-superset] branch master updated: Disable input when IS (NOT) NULL selected in filters (#5766) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Message-ID: <153550114827.10531.7300013799213706098@gitbox.apache.org> From: beto@apache.org X-Git-Host: gitbox.apache.org X-Git-Repo: incubator-superset X-Git-Refname: refs/heads/master X-Git-Reftype: branch X-Git-Oldrev: 6c6ea3730b91578184b57f41618979ab13d429c7 X-Git-Newrev: 48d220c03a484d9d4c9cde705128850b5d04b1b7 X-Git-Rev: 48d220c03a484d9d4c9cde705128850b5d04b1b7 X-Git-NotificationType: ref_changed_plus_diff X-Git-Multimail-Version: 1.5.dev Auto-Submitted: auto-generated This is an automated email from the ASF dual-hosted git repository. beto pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-superset.git The following commit(s) were added to refs/heads/master by this push: new 48d220c Disable input when IS (NOT) NULL selected in filters (#5766) 48d220c is described below commit 48d220c03a484d9d4c9cde705128850b5d04b1b7 Author: Beto Dealmeida AuthorDate: Tue Aug 28 17:05:44 2018 -0700 Disable input when IS (NOT) NULL selected in filters (#5766) --- .../src/explore/components/AdhocFilterEditPopoverSimpleTabContent.jsx | 1 + 1 file changed, 1 insertion(+) diff --git a/superset/assets/src/explore/components/AdhocFilterEditPopoverSimpleTabContent.jsx b/superset/assets/src/explore/components/AdhocFilterEditPopoverSimpleTabContent.jsx index 94535cd..6c670b6 100644 --- a/superset/assets/src/explore/components/AdhocFilterEditPopoverSimpleTabContent.jsx +++ b/superset/assets/src/explore/components/AdhocFilterEditPopoverSimpleTabContent.jsx @@ -283,6 +283,7 @@ export default class AdhocFilterEditPopoverSimpleTabContent extends React.Compon value={adhocFilter.comparator || ''} className="form-control input-sm" placeholder={t('Filter value')} + disabled={adhocFilter.operator === 'IS NOT NULL' || adhocFilter.operator === 'IS NULL'} /> }