From commits-return-1297-archive-asf-public=cust-asf.ponee.io@superset.incubator.apache.org Thu Aug 9 23:48:42 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 0FD9C18065B for ; Thu, 9 Aug 2018 23:48:41 +0200 (CEST) Received: (qmail 91505 invoked by uid 500); 9 Aug 2018 21:48:41 -0000 Mailing-List: contact commits-help@superset.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@superset.incubator.apache.org Delivered-To: mailing list commits@superset.incubator.apache.org Received: (qmail 91496 invoked by uid 99); 9 Aug 2018 21:48:41 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 09 Aug 2018 21:48:41 +0000 Received: by gitbox.apache.org (ASF Mail Server at gitbox.apache.org, from userid 33) id A3385852D5; Thu, 9 Aug 2018 21:48:40 +0000 (UTC) Date: Thu, 09 Aug 2018 21:48:40 +0000 To: "commits@superset.apache.org" Subject: [incubator-superset] branch master updated: [sql lab - explore flow] make sure groupby is empty (#5596) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Message-ID: <153385132045.29501.7514988103445102945@gitbox.apache.org> From: maximebeauchemin@apache.org X-Git-Host: gitbox.apache.org X-Git-Repo: incubator-superset X-Git-Refname: refs/heads/master X-Git-Reftype: branch X-Git-Oldrev: 21bf8d9f8ff8a32b3fda27bd29bb24c6d692dd57 X-Git-Newrev: 682ca3874e589f04726e6e83d51b86d406134147 X-Git-Rev: 682ca3874e589f04726e6e83d51b86d406134147 X-Git-NotificationType: ref_changed_plus_diff X-Git-Multimail-Version: 1.5.dev Auto-Submitted: auto-generated This is an automated email from the ASF dual-hosted git repository. maximebeauchemin pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-superset.git The following commit(s) were added to refs/heads/master by this push: new 682ca38 [sql lab - explore flow] make sure groupby is empty (#5596) 682ca38 is described below commit 682ca3874e589f04726e6e83d51b86d406134147 Author: Maxime Beauchemin AuthorDate: Thu Aug 9 14:48:36 2018 -0700 [sql lab - explore flow] make sure groupby is empty (#5596) --- superset/assets/src/SqlLab/components/ExploreResultsButton.jsx | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/superset/assets/src/SqlLab/components/ExploreResultsButton.jsx b/superset/assets/src/SqlLab/components/ExploreResultsButton.jsx index f5bbbe8..b641238 100644 --- a/superset/assets/src/SqlLab/components/ExploreResultsButton.jsx +++ b/superset/assets/src/SqlLab/components/ExploreResultsButton.jsx @@ -111,18 +111,15 @@ class ExploreResultsButton extends React.PureComponent { .done((resp) => { const columns = this.getColumns(); const data = JSON.parse(resp); - const mainGroupBy = columns.filter(d => d.is_dim)[0]; const formData = { datasource: `${data.table_id}__table`, metrics: [], + groupby: [], viz_type: 'table', since: '100 years ago', all_columns: columns.map(c => c.name), row_limit: 1000, }; - if (mainGroupBy) { - formData.groupby = [mainGroupBy.name]; - } this.props.actions.addInfoToast(t('Creating a data source and creating a new tab')); // open new window for data visualization