From commits-return-1292-archive-asf-public=cust-asf.ponee.io@superset.incubator.apache.org Tue Aug 7 22:22:27 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 3CD83180657 for ; Tue, 7 Aug 2018 22:22:27 +0200 (CEST) Received: (qmail 10655 invoked by uid 500); 7 Aug 2018 20:22:26 -0000 Mailing-List: contact commits-help@superset.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@superset.incubator.apache.org Delivered-To: mailing list commits@superset.incubator.apache.org Received: (qmail 10646 invoked by uid 99); 7 Aug 2018 20:22:26 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 07 Aug 2018 20:22:26 +0000 Received: by gitbox.apache.org (ASF Mail Server at gitbox.apache.org, from userid 33) id C4AC182A5A; Tue, 7 Aug 2018 20:22:25 +0000 (UTC) Date: Tue, 07 Aug 2018 20:22:25 +0000 To: "commits@superset.apache.org" Subject: [incubator-superset] branch master updated: update python3 version for testing to 3.6 (#5562) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Message-ID: <153367334559.15577.10432851874367337434@gitbox.apache.org> From: johnbodley@apache.org X-Git-Host: gitbox.apache.org X-Git-Repo: incubator-superset X-Git-Refname: refs/heads/master X-Git-Reftype: branch X-Git-Oldrev: ad469c72adc044b4a2885f07f9234fbef0820f09 X-Git-Newrev: 39ff9deb573fd0d34a2afdcb216092dccca8086b X-Git-Rev: 39ff9deb573fd0d34a2afdcb216092dccca8086b X-Git-NotificationType: ref_changed_plus_diff X-Git-Multimail-Version: 1.5.dev Auto-Submitted: auto-generated This is an automated email from the ASF dual-hosted git repository. johnbodley pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-superset.git The following commit(s) were added to refs/heads/master by this push: new 39ff9de update python3 version for testing to 3.6 (#5562) 39ff9de is described below commit 39ff9deb573fd0d34a2afdcb216092dccca8086b Author: Octavian AuthorDate: Tue Aug 7 22:22:19 2018 +0200 update python3 version for testing to 3.6 (#5562) * update python version for testing to 3.6 * CONTRIBUTING.md states pull requests should work on py27, py36+ * CONTRIBUTING.md states pull requests should work on py27 and py36 --- CONTRIBUTING.md | 4 ++-- docs/installation.rst | 2 +- tox.ini | 6 +++--- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 6e20d61..685d1f9 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -65,7 +65,7 @@ meets these guidelines: 3. If the pull request adds functionality, the docs should be updated as part of the same PR. Doc string are often sufficient, make sure to follow the sphinx compatible standards. -4. The pull request should work for Python 2.7, and ideally Python 3.4+. +4. The pull request should work for Python 2.7 and Python 3.6. ``from __future__ import`` will be required in every `.py` file soon. 5. If the pull request adds a Python dependency include it in `setup.py` denoting any specific restrictions and in `requirements.txt` pinned to a @@ -291,7 +291,7 @@ All python tests can be run with any of the tox [environments](http://tox.readth i.e., tox -e py27 - tox -e py34 + tox -e py36 Alternatively, you can run all tests in a single file via, diff --git a/docs/installation.rst b/docs/installation.rst index da6c8c4..ce97dbd 100644 --- a/docs/installation.rst +++ b/docs/installation.rst @@ -4,7 +4,7 @@ Installation & Configuration Getting Started --------------- -Superset is tested against Python ``2.7`` and Python ``3.4``. +Superset is tested against Python ``2.7`` and Python ``3.6``. Airbnb currently uses 2.7.* in production. We do not plan on supporting Python ``2.6``. diff --git a/tox.ini b/tox.ini index 06015d7..b73d276 100644 --- a/tox.ini +++ b/tox.ini @@ -37,9 +37,9 @@ setenv = SUPERSET_CONFIG = tests.superset_test_config SUPERSET_HOME = {envtmpdir} py27-mysql: SUPERSET__SQLALCHEMY_DATABASE_URI = mysql://mysqluser:mysqluserpassword@localhost/superset?charset=utf8 - py{34,36}-mysql: SUPERSET__SQLALCHEMY_DATABASE_URI = mysql://mysqluser:mysqluserpassword@localhost/superset - py{27,34,36}-postgres: SUPERSET__SQLALCHEMY_DATABASE_URI = postgresql+psycopg2://postgresuser:pguserpassword@localhost/superset - py{27,34,36}-sqlite: SUPERSET__SQLALCHEMY_DATABASE_URI = sqlite:////{envtmpdir}/superset.db + py36-mysql: SUPERSET__SQLALCHEMY_DATABASE_URI = mysql://mysqluser:mysqluserpassword@localhost/superset + py{27,36}-postgres: SUPERSET__SQLALCHEMY_DATABASE_URI = postgresql+psycopg2://postgresuser:pguserpassword@localhost/superset + py{27,36}-sqlite: SUPERSET__SQLALCHEMY_DATABASE_URI = sqlite:////{envtmpdir}/superset.db whitelist_externals = npm