From commits-return-1281-archive-asf-public=cust-asf.ponee.io@superset.incubator.apache.org Fri Aug 3 21:08:06 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 3C512180647 for ; Fri, 3 Aug 2018 21:08:06 +0200 (CEST) Received: (qmail 51747 invoked by uid 500); 3 Aug 2018 19:08:05 -0000 Mailing-List: contact commits-help@superset.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@superset.incubator.apache.org Delivered-To: mailing list commits@superset.incubator.apache.org Received: (qmail 51738 invoked by uid 99); 3 Aug 2018 19:08:05 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 03 Aug 2018 19:08:05 +0000 Received: by gitbox.apache.org (ASF Mail Server at gitbox.apache.org, from userid 33) id C813182115; Fri, 3 Aug 2018 19:08:04 +0000 (UTC) Date: Fri, 03 Aug 2018 19:08:04 +0000 To: "commits@superset.apache.org" Subject: [incubator-superset] branch master updated: permissions bug fixes (#5559) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Message-ID: <153332328456.17727.17650414124590567738@gitbox.apache.org> From: graceguo@apache.org X-Git-Host: gitbox.apache.org X-Git-Repo: incubator-superset X-Git-Refname: refs/heads/master X-Git-Reftype: branch X-Git-Oldrev: 8014709b1ad1fb9b5a17a36d680cab56f34cf38f X-Git-Newrev: 1e155663a7a61f882553bd9e070f149aba9e6ae7 X-Git-Rev: 1e155663a7a61f882553bd9e070f149aba9e6ae7 X-Git-NotificationType: ref_changed_plus_diff X-Git-Multimail-Version: 1.5.dev Auto-Submitted: auto-generated This is an automated email from the ASF dual-hosted git repository. graceguo pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-superset.git The following commit(s) were added to refs/heads/master by this push: new 1e15566 permissions bug fixes (#5559) 1e15566 is described below commit 1e155663a7a61f882553bd9e070f149aba9e6ae7 Author: timifasubaa <30888507+timifasubaa@users.noreply.github.com> AuthorDate: Fri Aug 3 12:08:00 2018 -0700 permissions bug fixes (#5559) --- superset/views/core.py | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/superset/views/core.py b/superset/views/core.py index 4c1752e..ca7746c 100755 --- a/superset/views/core.py +++ b/superset/views/core.py @@ -1093,8 +1093,7 @@ class Superset(BaseSupersetView): return json_error_response( security_manager.get_datasource_access_error_msg(viz_obj.datasource), status=404, - link=security_manager.security_manager.get_datasource_error_link( - viz_obj.datasource)) + link=security_manager.get_datasource_access_link(viz_obj.datasource)) if csv: return CsvResponse( @@ -2567,7 +2566,7 @@ class Superset(BaseSupersetView): if not security_manager.datasource_access(datasource): return json_error_response( security_manager.get_datasource_access_error_msg(datasource), - link=security_manager.get_datasource_error_link(datasource)) + link=security_manager.get_datasource_access_link(datasource)) return json_success(json.dumps(datasource.data)) @expose('/queries/') @@ -2747,7 +2746,7 @@ class Superset(BaseSupersetView): return json_error_response( security_manager.get_datasource_access_error_msg(viz_obj.datasource), status=401, - link=security_manager.get_datasource_error_link(viz_obj.datasource)) + link=security_manager.get_datasource_access_link(viz_obj.datasource)) return self.get_query_string_response(viz_obj)