superset-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From maximebeauche...@apache.org
Subject [incubator-superset] branch master updated: [sql lab - explore flow] make sure groupby is empty (#5596)
Date Thu, 09 Aug 2018 21:48:40 GMT
This is an automated email from the ASF dual-hosted git repository.

maximebeauchemin pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git


The following commit(s) were added to refs/heads/master by this push:
     new 682ca38  [sql lab - explore flow] make sure groupby is empty (#5596)
682ca38 is described below

commit 682ca3874e589f04726e6e83d51b86d406134147
Author: Maxime Beauchemin <maximebeauchemin@gmail.com>
AuthorDate: Thu Aug 9 14:48:36 2018 -0700

    [sql lab - explore flow] make sure groupby is empty (#5596)
---
 superset/assets/src/SqlLab/components/ExploreResultsButton.jsx | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/superset/assets/src/SqlLab/components/ExploreResultsButton.jsx b/superset/assets/src/SqlLab/components/ExploreResultsButton.jsx
index f5bbbe8..b641238 100644
--- a/superset/assets/src/SqlLab/components/ExploreResultsButton.jsx
+++ b/superset/assets/src/SqlLab/components/ExploreResultsButton.jsx
@@ -111,18 +111,15 @@ class ExploreResultsButton extends React.PureComponent {
       .done((resp) => {
         const columns = this.getColumns();
         const data = JSON.parse(resp);
-        const mainGroupBy = columns.filter(d => d.is_dim)[0];
         const formData = {
           datasource: `${data.table_id}__table`,
           metrics: [],
+          groupby: [],
           viz_type: 'table',
           since: '100 years ago',
           all_columns: columns.map(c => c.name),
           row_limit: 1000,
         };
-        if (mainGroupBy) {
-          formData.groupby = [mainGroupBy.name];
-        }
         this.props.actions.addInfoToast(t('Creating a data source and creating a new tab'));
 
         // open new window for data visualization


Mime
View raw message