superset-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ccwilli...@apache.org
Subject [incubator-superset] branch master updated: remove deep-equal and use _.isEqual instead (#5573)
Date Tue, 07 Aug 2018 00:26:09 GMT
This is an automated email from the ASF dual-hosted git repository.

ccwilliams pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git


The following commit(s) were added to refs/heads/master by this push:
     new 39acd9f  remove deep-equal and use _.isEqual instead (#5573)
39acd9f is described below

commit 39acd9ff7d6e369b3defc4f3b9b22216759855c9
Author: Krist Wongsuphasawat <krist.wongz@gmail.com>
AuthorDate: Mon Aug 6 17:26:06 2018 -0700

    remove deep-equal and use _.isEqual instead (#5573)
---
 superset/assets/package.json      | 1 -
 superset/assets/src/reduxUtils.js | 4 ++--
 superset/assets/yarn.lock         | 4 ----
 3 files changed, 2 insertions(+), 7 deletions(-)

diff --git a/superset/assets/package.json b/superset/assets/package.json
index a31942b..d66316a 100644
--- a/superset/assets/package.json
+++ b/superset/assets/package.json
@@ -61,7 +61,6 @@
     "datamaps": "^0.5.8",
     "datatables.net-bs": "^1.10.15",
     "deck.gl": "^5.1.4",
-    "deep-equal": "^1.0.1",
     "distributions": "^1.0.0",
     "dnd-core": "^2.6.0",
     "dompurify": "^1.0.3",
diff --git a/superset/assets/src/reduxUtils.js b/superset/assets/src/reduxUtils.js
index 17fcb65..8b1062a 100644
--- a/superset/assets/src/reduxUtils.js
+++ b/superset/assets/src/reduxUtils.js
@@ -1,7 +1,7 @@
 import shortid from 'shortid';
 import { compose } from 'redux';
 import persistState from 'redux-localstorage';
-import equals from 'deep-equal';
+import { isEqual } from 'underscore';
 
 export function addToObject(state, arrKey, obj) {
   const newObject = Object.assign({}, state[arrKey]);
@@ -95,5 +95,5 @@ export function areArraysShallowEqual(arr1, arr2) {
 }
 
 export function areObjectsEqual(obj1, obj2) {
-  return equals(obj1, obj2, true);
+  return isEqual(obj1, obj2);
 }
diff --git a/superset/assets/yarn.lock b/superset/assets/yarn.lock
index c0cc045..669ab3a 100644
--- a/superset/assets/yarn.lock
+++ b/superset/assets/yarn.lock
@@ -3420,10 +3420,6 @@ deep-eql@^3.0.0:
   dependencies:
     type-detect "^4.0.0"
 
-deep-equal@^1.0.1:
-  version "1.0.1"
-  resolved "https://registry.yarnpkg.com/deep-equal/-/deep-equal-1.0.1.tgz#f5d260292b660e084eff4cdbc9f08ad3247448b5"
-
 deep-extend@^0.6.0:
   version "0.6.0"
   resolved "https://registry.yarnpkg.com/deep-extend/-/deep-extend-0.6.0.tgz#c4fa7c95404a17a9c3e8ca7e1537312b736330ac"


Mime
View raw message