From commits-return-1251-archive-asf-public=cust-asf.ponee.io@superset.incubator.apache.org Fri Jul 27 18:49:13 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 83593180657 for ; Fri, 27 Jul 2018 18:49:13 +0200 (CEST) Received: (qmail 42016 invoked by uid 500); 27 Jul 2018 16:49:12 -0000 Mailing-List: contact commits-help@superset.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@superset.incubator.apache.org Delivered-To: mailing list commits@superset.incubator.apache.org Received: (qmail 42007 invoked by uid 99); 27 Jul 2018 16:49:12 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 27 Jul 2018 16:49:12 +0000 Received: by gitbox.apache.org (ASF Mail Server at gitbox.apache.org, from userid 33) id 1170C82A5F; Fri, 27 Jul 2018 16:49:12 +0000 (UTC) Date: Fri, 27 Jul 2018 16:49:11 +0000 To: "commits@superset.apache.org" Subject: [incubator-superset] branch master updated: Fix 5479 - unicode columns issue. (#5508) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Message-ID: <153271015186.29679.7340833714410985001@gitbox.apache.org> From: maximebeauchemin@apache.org X-Git-Host: gitbox.apache.org X-Git-Repo: incubator-superset X-Git-Refname: refs/heads/master X-Git-Reftype: branch X-Git-Oldrev: cd55998d6319d8c3ce27f0b9a01e0e12f5300473 X-Git-Newrev: 213fb649e6873f575106483eed8e8114c06023d7 X-Git-Rev: 213fb649e6873f575106483eed8e8114c06023d7 X-Git-NotificationType: ref_changed_plus_diff X-Git-Multimail-Version: 1.5.dev Auto-Submitted: auto-generated This is an automated email from the ASF dual-hosted git repository. maximebeauchemin pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-superset.git The following commit(s) were added to refs/heads/master by this push: new 213fb64 Fix 5479 - unicode columns issue. (#5508) 213fb64 is described below commit 213fb649e6873f575106483eed8e8114c06023d7 Author: mmuru AuthorDate: Fri Jul 27 09:49:08 2018 -0700 Fix 5479 - unicode columns issue. (#5508) --- superset/models/core.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/superset/models/core.py b/superset/models/core.py index 7ae9297..60af53d 100644 --- a/superset/models/core.py +++ b/superset/models/core.py @@ -726,7 +726,7 @@ class Database(Model, AuditMixinNullable, ImportMixin): return self.get_dialect().identifier_preparer.quote def get_df(self, sql, schema): - sqls = [str(s).strip().strip(';') for s in sqlparse.parse(sql)] + sqls = [six.text_type(s).strip().strip(';') for s in sqlparse.parse(sql)] engine = self.get_sqla_engine(schema=schema) def needs_conversion(df_series):