superset-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From grace...@apache.org
Subject [incubator-superset] branch master updated: [migration] bug fix in dashboard migration (bebcf3fed1fe_) (#5497)
Date Thu, 26 Jul 2018 20:15:12 GMT
This is an automated email from the ASF dual-hosted git repository.

graceguo pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git


The following commit(s) were added to refs/heads/master by this push:
     new 7ff02c0  [migration] bug fix in dashboard migration (bebcf3fed1fe_) (#5497)
7ff02c0 is described below

commit 7ff02c0050cf356fb801aafd186ce436af03b1ce
Author: Grace Guo <grace.guo@airbnb.com>
AuthorDate: Thu Jul 26 13:15:09 2018 -0700

    [migration] bug fix in dashboard migration (bebcf3fed1fe_) (#5497)
    
    fix a bug in handle empty rows
---
 .../versions/bebcf3fed1fe_convert_dashboard_v1_positions.py           | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/superset/migrations/versions/bebcf3fed1fe_convert_dashboard_v1_positions.py b/superset/migrations/versions/bebcf3fed1fe_convert_dashboard_v1_positions.py
index aa2d95d..5767401 100644
--- a/superset/migrations/versions/bebcf3fed1fe_convert_dashboard_v1_positions.py
+++ b/superset/migrations/versions/bebcf3fed1fe_convert_dashboard_v1_positions.py
@@ -351,13 +351,13 @@ def convert(positions, level, parent, root):
     # they can be a list of charts, or arranged in columns, or mixed
     for layer in layers:
         if len(layer) == 0:
-            return
+            continue
 
         if len(layer) == 1 and parent['type'] == COLUMN_TYPE:
             chart_holder = get_chart_holder(layer[0])
             root[chart_holder['id']] = chart_holder
             parent['children'].append(chart_holder['id'])
-            return
+            continue
 
         # create a new row
         row_container = get_row_container()


Mime
View raw message