From commits-return-1058-archive-asf-public=cust-asf.ponee.io@superset.incubator.apache.org Wed Jun 6 02:24:27 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 3AAA6180625 for ; Wed, 6 Jun 2018 02:24:27 +0200 (CEST) Received: (qmail 15734 invoked by uid 500); 6 Jun 2018 00:24:26 -0000 Mailing-List: contact commits-help@superset.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@superset.incubator.apache.org Delivered-To: mailing list commits@superset.incubator.apache.org Received: (qmail 15725 invoked by uid 99); 6 Jun 2018 00:24:26 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 06 Jun 2018 00:24:26 +0000 Received: by gitbox.apache.org (ASF Mail Server at gitbox.apache.org, from userid 33) id C91BC82A59; Wed, 6 Jun 2018 00:24:25 +0000 (UTC) Date: Wed, 06 Jun 2018 00:24:25 +0000 To: "commits@superset.apache.org" Subject: [incubator-superset] branch master updated: [crud] Improving performance (#5136) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Message-ID: <152824466564.16674.13218569175637840545@gitbox.apache.org> From: johnbodley@apache.org X-Git-Host: gitbox.apache.org X-Git-Repo: incubator-superset X-Git-Refname: refs/heads/master X-Git-Reftype: branch X-Git-Oldrev: b71f551493e18c26daafa171ccf95bf934c58584 X-Git-Newrev: f102eab33ce3a7246da267786ec07c391c6662d6 X-Git-Rev: f102eab33ce3a7246da267786ec07c391c6662d6 X-Git-NotificationType: ref_changed_plus_diff X-Git-Multimail-Version: 1.5.dev Auto-Submitted: auto-generated This is an automated email from the ASF dual-hosted git repository. johnbodley pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-superset.git The following commit(s) were added to refs/heads/master by this push: new f102eab [crud] Improving performance (#5136) f102eab is described below commit f102eab33ce3a7246da267786ec07c391c6662d6 Author: John Bodley <4567245+john-bodley@users.noreply.github.com> AuthorDate: Tue Jun 5 17:24:19 2018 -0700 [crud] Improving performance (#5136) --- superset/connectors/sqla/views.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/superset/connectors/sqla/views.py b/superset/connectors/sqla/views.py index ca6f5a5..b46af10 100644 --- a/superset/connectors/sqla/views.py +++ b/superset/connectors/sqla/views.py @@ -165,14 +165,14 @@ class TableModelView(DatasourceModelView, DeleteMixin, YamlExportMixin): # noqa order_columns = ['modified'] add_columns = ['database', 'schema', 'table_name'] edit_columns = [ - 'table_name', 'sql', 'filter_select_enabled', 'slices', + 'table_name', 'sql', 'filter_select_enabled', 'fetch_values_predicate', 'database', 'schema', 'description', 'owner', 'main_dttm_col', 'default_endpoint', 'offset', 'cache_timeout', 'is_sqllab_view', 'template_params', ] base_filters = [['id', DatasourceFilter, lambda: []]] - show_columns = edit_columns + ['perm'] + show_columns = edit_columns + ['perm', 'slices'] related_views = [TableColumnInlineView, SqlMetricInlineView] base_order = ('changed_on', 'desc') search_columns = ( -- To stop receiving notification emails like this one, please contact johnbodley@apache.org.