From commits-return-1046-archive-asf-public=cust-asf.ponee.io@superset.incubator.apache.org Fri Jun 1 06:00:27 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 63AD5180632 for ; Fri, 1 Jun 2018 06:00:26 +0200 (CEST) Received: (qmail 99005 invoked by uid 500); 1 Jun 2018 04:00:25 -0000 Mailing-List: contact commits-help@superset.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@superset.incubator.apache.org Delivered-To: mailing list commits@superset.incubator.apache.org Received: (qmail 98996 invoked by uid 99); 1 Jun 2018 04:00:25 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 01 Jun 2018 04:00:25 +0000 Received: by gitbox.apache.org (ASF Mail Server at gitbox.apache.org, from userid 33) id A814F82A66; Fri, 1 Jun 2018 04:00:24 +0000 (UTC) Date: Fri, 01 Jun 2018 04:00:24 +0000 To: "commits@superset.apache.org" Subject: [incubator-superset] branch master updated: adding null checks to adhoc filter popover (#5111) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Message-ID: <152782562409.16850.6243354991117767364@gitbox.apache.org> From: maximebeauchemin@apache.org X-Git-Host: gitbox.apache.org X-Git-Repo: incubator-superset X-Git-Refname: refs/heads/master X-Git-Reftype: branch X-Git-Oldrev: 28611108d7c60d355dada9eb93d5beaa230d6b5f X-Git-Newrev: 40fadfcb4f7decc364f3f875fcd5723d81145ad8 X-Git-Rev: 40fadfcb4f7decc364f3f875fcd5723d81145ad8 X-Git-NotificationType: ref_changed_plus_diff X-Git-Multimail-Version: 1.5.dev Auto-Submitted: auto-generated This is an automated email from the ASF dual-hosted git repository. maximebeauchemin pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-superset.git The following commit(s) were added to refs/heads/master by this push: new 40fadfc adding null checks to adhoc filter popover (#5111) 40fadfc is described below commit 40fadfcb4f7decc364f3f875fcd5723d81145ad8 Author: Gabe Lyons AuthorDate: Thu May 31 21:00:20 2018 -0700 adding null checks to adhoc filter popover (#5111) --- .../explore/components/AdhocFilterEditPopoverSimpleTabContent.jsx | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/superset/assets/src/explore/components/AdhocFilterEditPopoverSimpleTabContent.jsx b/superset/assets/src/explore/components/AdhocFilterEditPopoverSimpleTabContent.jsx index bf8fa1d..222772a 100644 --- a/superset/assets/src/explore/components/AdhocFilterEditPopoverSimpleTabContent.jsx +++ b/superset/assets/src/explore/components/AdhocFilterEditPopoverSimpleTabContent.jsx @@ -141,8 +141,10 @@ export default class AdhocFilterEditPopoverSimpleTabContent extends React.Compon handleMultiComparatorInputHeightChange() { if (this.multiComparatorComponent) { - // eslint-disable-next-line no-underscore-dangle - const multiComparatorDOMNode = this.multiComparatorComponent._selectRef.select.control; + /* eslint-disable no-underscore-dangle */ + const multiComparatorDOMNode = this.multiComparatorComponent._selectRef && + this.multiComparatorComponent._selectRef.select && + this.multiComparatorComponent._selectRef.select.control; if (multiComparatorDOMNode) { if (multiComparatorDOMNode.clientHeight !== this.state.multiComparatorHeight) { this.props.onHeightChange(( -- To stop receiving notification emails like this one, please contact maximebeauchemin@apache.org.