superset-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From grace...@apache.org
Subject [incubator-superset] branch dashboard-builder updated: Fix: Should pass slice_can_edit flag down (#5159)
Date Thu, 07 Jun 2018 18:03:18 GMT
This is an automated email from the ASF dual-hosted git repository.

graceguo pushed a commit to branch dashboard-builder
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git


The following commit(s) were added to refs/heads/dashboard-builder by this push:
     new 4d13dae  Fix: Should pass slice_can_edit flag down (#5159)
4d13dae is described below

commit 4d13daeab6210c808d8489f2ed00ba605c20baa0
Author: Grace Guo <grace.guo@airbnb.com>
AuthorDate: Thu Jun 7 11:03:11 2018 -0700

    Fix: Should pass slice_can_edit flag down (#5159)
---
 superset/assets/src/dashboard/components/SliceHeader.jsx | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/superset/assets/src/dashboard/components/SliceHeader.jsx b/superset/assets/src/dashboard/components/SliceHeader.jsx
index 50a2a5d..d812181 100644
--- a/superset/assets/src/dashboard/components/SliceHeader.jsx
+++ b/superset/assets/src/dashboard/components/SliceHeader.jsx
@@ -22,6 +22,7 @@ const propTypes = {
   annotationError: PropTypes.object,
   sliceName: PropTypes.string,
   supersetCanExplore: PropTypes.bool,
+  sliceCanEdit: PropTypes.bool,
 };
 
 const defaultProps = {
@@ -40,6 +41,7 @@ const defaultProps = {
   isExpanded: false,
   sliceName: '',
   supersetCanExplore: false,
+  sliceCanEdit: false,
 };
 
 class SliceHeader extends React.PureComponent {
@@ -56,6 +58,7 @@ class SliceHeader extends React.PureComponent {
       innerRef,
       sliceName,
       supersetCanExplore,
+      sliceCanEdit,
     } = this.props;
 
     const annoationsLoading = t('Annotation layers are still loading.');
@@ -104,6 +107,7 @@ class SliceHeader extends React.PureComponent {
               exploreChart={exploreChart}
               exportCSV={exportCSV}
               supersetCanExplore={supersetCanExplore}
+              sliceCanEdit={sliceCanEdit}
             />
           )}
         </div>

-- 
To stop receiving notification emails like this one, please contact
graceguo@apache.org.

Mime
View raw message