From commits-return-992-archive-asf-public=cust-asf.ponee.io@superset.incubator.apache.org Mon May 14 21:09:17 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id BBCED180627 for ; Mon, 14 May 2018 21:09:16 +0200 (CEST) Received: (qmail 92575 invoked by uid 500); 14 May 2018 19:09:15 -0000 Mailing-List: contact commits-help@superset.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@superset.incubator.apache.org Delivered-To: mailing list commits@superset.incubator.apache.org Received: (qmail 92566 invoked by uid 99); 14 May 2018 19:09:15 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 14 May 2018 19:09:15 +0000 Received: by gitbox.apache.org (ASF Mail Server at gitbox.apache.org, from userid 33) id 2BFC28061F; Mon, 14 May 2018 19:09:15 +0000 (UTC) Date: Mon, 14 May 2018 19:09:15 +0000 To: "commits@superset.apache.org" Subject: [incubator-superset] branch master updated: cleaning up the table fab view since we hide these autogenerated metrics anyway (#4992) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Message-ID: <152632495498.15579.3063492537896695115@gitbox.apache.org> From: maximebeauchemin@apache.org X-Git-Host: gitbox.apache.org X-Git-Repo: incubator-superset X-Git-Refname: refs/heads/master X-Git-Reftype: branch X-Git-Oldrev: b391676544ee139d0478f51abb77d59721794aba X-Git-Newrev: ce710f8c8ff3feaef307e4b0f2f1a7560b7f95d5 X-Git-Rev: ce710f8c8ff3feaef307e4b0f2f1a7560b7f95d5 X-Git-NotificationType: ref_changed_plus_diff X-Git-Multimail-Version: 1.5.dev Auto-Submitted: auto-generated This is an automated email from the ASF dual-hosted git repository. maximebeauchemin pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-superset.git The following commit(s) were added to refs/heads/master by this push: new ce710f8 cleaning up the table fab view since we hide these autogenerated metrics anyway (#4992) ce710f8 is described below commit ce710f8c8ff3feaef307e4b0f2f1a7560b7f95d5 Author: Gabe Lyons AuthorDate: Mon May 14 12:09:12 2018 -0700 cleaning up the table fab view since we hide these autogenerated metrics anyway (#4992) --- superset/connectors/sqla/views.py | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/superset/connectors/sqla/views.py b/superset/connectors/sqla/views.py index f0f5afb..b73a29c 100644 --- a/superset/connectors/sqla/views.py +++ b/superset/connectors/sqla/views.py @@ -37,12 +37,12 @@ class TableColumnInlineView(CompactCRUDMixin, SupersetModelView): # noqa edit_columns = [ 'column_name', 'verbose_name', 'description', 'type', 'groupby', 'filterable', - 'table', 'count_distinct', 'sum', 'min', 'max', 'expression', + 'table', 'expression', 'is_dttm', 'python_date_format', 'database_expression'] add_columns = edit_columns list_columns = [ - 'column_name', 'verbose_name', 'type', 'groupby', 'filterable', 'count_distinct', - 'sum', 'min', 'max', 'is_dttm'] + 'column_name', 'verbose_name', 'type', 'groupby', 'filterable', + 'is_dttm'] page_size = 500 description_columns = { 'is_dttm': _( @@ -86,10 +86,6 @@ class TableColumnInlineView(CompactCRUDMixin, SupersetModelView): # noqa 'groupby': _('Groupable'), 'filterable': _('Filterable'), 'table': _('Table'), - 'count_distinct': _('Count Distinct'), - 'sum': _('Sum'), - 'min': _('Min'), - 'max': _('Max'), 'expression': _('Expression'), 'is_dttm': _('Is temporal'), 'python_date_format': _('Datetime Format'), -- To stop receiving notification emails like this one, please contact maximebeauchemin@apache.org.