From commits-return-918-archive-asf-public=cust-asf.ponee.io@superset.incubator.apache.org Fri Apr 20 23:36:25 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id BC635180645 for ; Fri, 20 Apr 2018 23:36:24 +0200 (CEST) Received: (qmail 65916 invoked by uid 500); 20 Apr 2018 21:36:23 -0000 Mailing-List: contact commits-help@superset.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@superset.incubator.apache.org Delivered-To: mailing list commits@superset.incubator.apache.org Received: (qmail 65907 invoked by uid 99); 20 Apr 2018 21:36:23 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 20 Apr 2018 21:36:23 +0000 Received: by gitbox.apache.org (ASF Mail Server at gitbox.apache.org, from userid 33) id 1668B81DEE; Fri, 20 Apr 2018 21:36:23 +0000 (UTC) Date: Fri, 20 Apr 2018 21:36:23 +0000 To: "commits@superset.apache.org" Subject: [incubator-superset] branch master updated: [sql] Using read_sql_query instead of read_sql (#4853) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Message-ID: <152426018292.16946.15833476186655217171@gitbox.apache.org> From: johnbodley@apache.org X-Git-Host: gitbox.apache.org X-Git-Repo: incubator-superset X-Git-Refname: refs/heads/master X-Git-Reftype: branch X-Git-Oldrev: c92b56e2f61ad8d8b74f569501b1318fdd89dbe4 X-Git-Newrev: 89347172d22688d110e24df3cfc35efe77dce45c X-Git-Rev: 89347172d22688d110e24df3cfc35efe77dce45c X-Git-NotificationType: ref_changed_plus_diff X-Git-Multimail-Version: 1.5.dev Auto-Submitted: auto-generated This is an automated email from the ASF dual-hosted git repository. johnbodley pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-superset.git The following commit(s) were added to refs/heads/master by this push: new 8934717 [sql] Using read_sql_query instead of read_sql (#4853) 8934717 is described below commit 89347172d22688d110e24df3cfc35efe77dce45c Author: John Bodley <4567245+john-bodley@users.noreply.github.com> AuthorDate: Fri Apr 20 14:36:20 2018 -0700 [sql] Using read_sql_query instead of read_sql (#4853) --- superset/models/core.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/superset/models/core.py b/superset/models/core.py index 05f781f..576f561 100644 --- a/superset/models/core.py +++ b/superset/models/core.py @@ -693,7 +693,7 @@ class Database(Model, AuditMixinNullable, ImportMixin): def get_df(self, sql, schema): sql = sql.strip().strip(';') eng = self.get_sqla_engine(schema=schema) - df = pd.read_sql(sql, eng) + df = pd.read_sql_query(sql, eng) def needs_conversion(df_series): if df_series.empty: -- To stop receiving notification emails like this one, please contact johnbodley@apache.org.