superset-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From maximebeauche...@apache.org
Subject [incubator-superset] branch master updated: Make the bottom margin a bit taller (#4807)
Date Wed, 11 Apr 2018 22:16:03 GMT
This is an automated email from the ASF dual-hosted git repository.

maximebeauchemin pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git


The following commit(s) were added to refs/heads/master by this push:
     new 683fb6c  Make the bottom margin a bit taller (#4807)
683fb6c is described below

commit 683fb6c251b09d89540abbde3b20fb2c77315ae4
Author: Maxime Beauchemin <maximebeauchemin@gmail.com>
AuthorDate: Wed Apr 11 15:15:59 2018 -0700

    Make the bottom margin a bit taller (#4807)
---
 superset/assets/visualizations/nvd3_vis.js | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/superset/assets/visualizations/nvd3_vis.js b/superset/assets/visualizations/nvd3_vis.js
index eb5b701..284c4e0 100644
--- a/superset/assets/visualizations/nvd3_vis.js
+++ b/superset/assets/visualizations/nvd3_vis.js
@@ -493,7 +493,7 @@ export default function nvd3Vis(slice, payload) {
       // ---- (x axis labels are rotated 45 degrees so we use height),
       // - adjust margins based on these measures and render again
       const margins = chart.margin();
-      margins.bottom = 20;
+      margins.bottom = 28;
       if (fd.x_axis_showminmax) {
         // If x bounds are shown, we need a right margin
         margins.right = Math.max(20, maxXAxisLabelHeight / 2) + marginPad;
@@ -502,7 +502,7 @@ export default function nvd3Vis(slice, payload) {
         margins.bottom = maxXAxisLabelHeight + marginPad;
         margins.right = maxXAxisLabelHeight + marginPad;
       } else if (staggerLabels) {
-        margins.bottom = 30;
+        margins.bottom = 40;
       }
 
       if (vizType === 'dual_line') {

-- 
To stop receiving notification emails like this one, please contact
maximebeauchemin@apache.org.

Mime
View raw message