superset-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From maximebeauche...@apache.org
Subject [incubator-superset] branch master updated: [bugfix] dedup groupby columns in Deck visualizations (#4801)
Date Wed, 11 Apr 2018 22:15:39 GMT
This is an automated email from the ASF dual-hosted git repository.

maximebeauchemin pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git


The following commit(s) were added to refs/heads/master by this push:
     new 07a5f47  [bugfix] dedup groupby columns in Deck visualizations (#4801)
07a5f47 is described below

commit 07a5f47c75abf04d5fe4f9b2d1dcd02352d66261
Author: Maxime Beauchemin <maximebeauchemin@gmail.com>
AuthorDate: Wed Apr 11 15:15:36 2018 -0700

    [bugfix] dedup groupby columns in Deck visualizations (#4801)
    
    When specifying the same column twice as a `Extra Data for JS` and
    `Categorical Color`, an error is issued. This addresses this issue.
---
 superset/viz.py | 1 +
 1 file changed, 1 insertion(+)

diff --git a/superset/viz.py b/superset/viz.py
index f27406b..dee7e56 100644
--- a/superset/viz.py
+++ b/superset/viz.py
@@ -2036,6 +2036,7 @@ class BaseDeckGLViz(BaseViz):
         if fd.get('js_columns'):
             gb += fd.get('js_columns')
         metrics = self.get_metrics()
+        gb = list(set(gb))
         if metrics:
             d['groupby'] = gb
             d['metrics'] = self.get_metrics()

-- 
To stop receiving notification emails like this one, please contact
maximebeauchemin@apache.org.

Mime
View raw message