From commits-return-811-archive-asf-public=cust-asf.ponee.io@superset.incubator.apache.org Fri Mar 23 23:31:52 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 72F0618064D for ; Fri, 23 Mar 2018 23:31:52 +0100 (CET) Received: (qmail 22294 invoked by uid 500); 23 Mar 2018 22:31:51 -0000 Mailing-List: contact commits-help@superset.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@superset.incubator.apache.org Delivered-To: mailing list commits@superset.incubator.apache.org Received: (qmail 22285 invoked by uid 99); 23 Mar 2018 22:31:51 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 23 Mar 2018 22:31:51 +0000 Received: by gitbox.apache.org (ASF Mail Server at gitbox.apache.org, from userid 33) id F202880AF6; Fri, 23 Mar 2018 22:31:50 +0000 (UTC) Date: Fri, 23 Mar 2018 22:31:50 +0000 To: "commits@superset.apache.org" Subject: [incubator-superset] branch master updated: add yarn lock info to contributing.md (#4679) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Message-ID: <152184431081.18620.9601598140176487055@gitbox.apache.org> From: johnbodley@apache.org X-Git-Host: gitbox.apache.org X-Git-Repo: incubator-superset X-Git-Refname: refs/heads/master X-Git-Reftype: branch X-Git-Oldrev: 76394d3f8f711c2754dbfdd0c6cf7deb6d3ef122 X-Git-Newrev: 00cab7e1073ba8d810b5dd323cb6fdb706ced537 X-Git-Rev: 00cab7e1073ba8d810b5dd323cb6fdb706ced537 X-Git-NotificationType: ref_changed_plus_diff X-Git-Multimail-Version: 1.5.dev Auto-Submitted: auto-generated This is an automated email from the ASF dual-hosted git repository. johnbodley pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-superset.git The following commit(s) were added to refs/heads/master by this push: new 00cab7e add yarn lock info to contributing.md (#4679) 00cab7e is described below commit 00cab7e1073ba8d810b5dd323cb6fdb706ced537 Author: timifasubaa <30888507+timifasubaa@users.noreply.github.com> AuthorDate: Fri Mar 23 15:31:47 2018 -0700 add yarn lock info to contributing.md (#4679) --- CONTRIBUTING.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index b337dad..7f7ff50 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -259,6 +259,10 @@ superset runserver -d -p 8081 npm run dev ``` +#### Upgrading npm packages + +Should you add or upgrade a npm package, which involves changing `package.json`, you'll need to re-run `yarn install` and push the newly generated `yarn.lock` file so we get the reproducible build. More information at (https://yarnpkg.com/blog/2016/11/24/lockfiles-for-all/) + ## Testing Before running python unit tests, please setup local testing environment: -- To stop receiving notification emails like this one, please contact johnbodley@apache.org.