From commits-return-779-archive-asf-public=cust-asf.ponee.io@superset.incubator.apache.org Fri Mar 16 07:00:28 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 671BB180608 for ; Fri, 16 Mar 2018 07:00:28 +0100 (CET) Received: (qmail 20251 invoked by uid 500); 16 Mar 2018 06:00:27 -0000 Mailing-List: contact commits-help@superset.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@superset.incubator.apache.org Delivered-To: mailing list commits@superset.incubator.apache.org Received: (qmail 20242 invoked by uid 99); 16 Mar 2018 06:00:27 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 16 Mar 2018 06:00:27 +0000 Received: by gitbox.apache.org (ASF Mail Server at gitbox.apache.org, from userid 33) id 8158E80856; Fri, 16 Mar 2018 06:00:26 +0000 (UTC) Date: Fri, 16 Mar 2018 06:00:26 +0000 To: "commits@superset.apache.org" Subject: [incubator-superset] branch chris--top-level-tabs updated: [top-level-tabs] improve tab drag and drop css MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Message-ID: <152118002636.27814.11415637132435899044@gitbox.apache.org> From: ccwilliams@apache.org X-Git-Host: gitbox.apache.org X-Git-Repo: incubator-superset X-Git-Refname: refs/heads/chris--top-level-tabs X-Git-Reftype: branch X-Git-Oldrev: 82bd8a181d9ca952a37a73f8469a625936e74376 X-Git-Newrev: bdc5dfeeafd7e423ea332965bef5e12a66f5871e X-Git-Rev: bdc5dfeeafd7e423ea332965bef5e12a66f5871e X-Git-NotificationType: ref_changed_plus_diff X-Git-Multimail-Version: 1.5.dev Auto-Submitted: auto-generated This is an automated email from the ASF dual-hosted git repository. ccwilliams pushed a commit to branch chris--top-level-tabs in repository https://gitbox.apache.org/repos/asf/incubator-superset.git The following commit(s) were added to refs/heads/chris--top-level-tabs by this push: new bdc5dfe [top-level-tabs] improve tab drag and drop css bdc5dfe is described below commit bdc5dfeeafd7e423ea332965bef5e12a66f5871e Author: Chris Williams AuthorDate: Thu Mar 15 23:00:01 2018 -0700 [top-level-tabs] improve tab drag and drop css --- .../dashboard/v2/stylesheets/components/column.less | 2 +- .../dashboard/v2/stylesheets/components/new-component.less | 1 + .../dashboard/v2/stylesheets/components/row.less | 2 +- .../dashboard/v2/stylesheets/components/tabs.less | 13 ++++++++----- .../assets/javascripts/dashboard/v2/stylesheets/dnd.less | 2 +- .../javascripts/dashboard/v2/stylesheets/popover-menu.less | 12 ++++++++++++ 6 files changed, 24 insertions(+), 8 deletions(-) diff --git a/superset/assets/javascripts/dashboard/v2/stylesheets/components/column.less b/superset/assets/javascripts/dashboard/v2/stylesheets/components/column.less index b96b14b..0b96f78 100644 --- a/superset/assets/javascripts/dashboard/v2/stylesheets/components/column.less +++ b/superset/assets/javascripts/dashboard/v2/stylesheets/components/column.less @@ -7,7 +7,7 @@ top: -20px; } -.grid-column--empty:after { +.grid-column--empty:before { content: "Empty column"; position: absolute; top: 0; diff --git a/superset/assets/javascripts/dashboard/v2/stylesheets/components/new-component.less b/superset/assets/javascripts/dashboard/v2/stylesheets/components/new-component.less index 31e84cb..e36fee2 100644 --- a/superset/assets/javascripts/dashboard/v2/stylesheets/components/new-component.less +++ b/superset/assets/javascripts/dashboard/v2/stylesheets/components/new-component.less @@ -5,6 +5,7 @@ align-items: center; padding: 16px; background: white; + cursor: move; } .new-component-placeholder { diff --git a/superset/assets/javascripts/dashboard/v2/stylesheets/components/row.less b/superset/assets/javascripts/dashboard/v2/stylesheets/components/row.less index 8859926..f4e1ed8 100644 --- a/superset/assets/javascripts/dashboard/v2/stylesheets/components/row.less +++ b/superset/assets/javascripts/dashboard/v2/stylesheets/components/row.less @@ -25,7 +25,7 @@ height: 80px; } -.grid-row--empty:after { +.grid-row--empty:before { position: absolute; top: 0; left: 0; diff --git a/superset/assets/javascripts/dashboard/v2/stylesheets/components/tabs.less b/superset/assets/javascripts/dashboard/v2/stylesheets/components/tabs.less index f86365f..1bf79dc 100644 --- a/superset/assets/javascripts/dashboard/v2/stylesheets/components/tabs.less +++ b/superset/assets/javascripts/dashboard/v2/stylesheets/components/tabs.less @@ -14,7 +14,7 @@ /* by moving padding from to
  • we can restrict the selected tab indicator to text width */ .dashboard-component-tabs .nav-tabs > li { - padding: 0 16px; + margin: 0 16px; } .dashboard-component-tabs .nav-tabs > li > a { @@ -53,12 +53,15 @@ } .dashboard-component-tabs .nav-tabs > li .drop-indicator { - height: 40px !important; - top: -10px !important; - opacity: 0.5; + top: -12px !important; + left: -12px !important; + width: ~"calc(100% + 24px)" !important; /* escape for .less */ + height: ~"calc(100% + 24px)" !important; + opacity: 0.4; } -.dashboard-component-tabs .fa-plus-square { +.dashboard-component-tabs li .fa { color: @almost-black; font-size: 14px; + margin-top: 3px; } diff --git a/superset/assets/javascripts/dashboard/v2/stylesheets/dnd.less b/superset/assets/javascripts/dashboard/v2/stylesheets/dnd.less index 7d64609..cb1d46c 100644 --- a/superset/assets/javascripts/dashboard/v2/stylesheets/dnd.less +++ b/superset/assets/javascripts/dashboard/v2/stylesheets/dnd.less @@ -3,7 +3,7 @@ } .dragdroppable--dragging { - opacity: 0.25; + opacity: 0.15; } .dragdroppable-row { diff --git a/superset/assets/javascripts/dashboard/v2/stylesheets/popover-menu.less b/superset/assets/javascripts/dashboard/v2/stylesheets/popover-menu.less index f68cf13..0f2466b 100644 --- a/superset/assets/javascripts/dashboard/v2/stylesheets/popover-menu.less +++ b/superset/assets/javascripts/dashboard/v2/stylesheets/popover-menu.less @@ -37,6 +37,18 @@ z-index: 10; } +/* the focus menu doesn't account for parent padding */ +.dashboard-component-tabs li .with-popover-menu--focused:after { + top: -12px; + left: -2px; + width: ~"calc(100% + 4px)"; /* escape for .less */ + height: ~"calc(100% + 28px)"; +} + +.dashboard-component-tabs li .popover-menu { + top: -56px; +} + .popover-menu .menu-item { display: flex; flex-direction: row; -- To stop receiving notification emails like this one, please contact ccwilliams@apache.org.