superset-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From johnbod...@apache.org
Subject [incubator-superset] branch master updated: add yarn lock info to contributing.md (#4679)
Date Fri, 23 Mar 2018 22:31:50 GMT
This is an automated email from the ASF dual-hosted git repository.

johnbodley pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git


The following commit(s) were added to refs/heads/master by this push:
     new 00cab7e  add yarn lock info to contributing.md (#4679)
00cab7e is described below

commit 00cab7e1073ba8d810b5dd323cb6fdb706ced537
Author: timifasubaa <30888507+timifasubaa@users.noreply.github.com>
AuthorDate: Fri Mar 23 15:31:47 2018 -0700

    add yarn lock info to contributing.md (#4679)
---
 CONTRIBUTING.md | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
index b337dad..7f7ff50 100644
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -259,6 +259,10 @@ superset runserver -d -p 8081
 npm run dev
 ```
 
+#### Upgrading npm packages
+
+Should you add or upgrade a npm package, which involves changing `package.json`, you'll need
to re-run `yarn install` and push the newly generated `yarn.lock` file so we get the reproducible
build. More information at (https://yarnpkg.com/blog/2016/11/24/lockfiles-for-all/)
+
 ## Testing
 
 Before running python unit tests, please setup local testing environment:

-- 
To stop receiving notification emails like this one, please contact
johnbodley@apache.org.

Mime
View raw message